Fixing mouse focus on WebView

content/browser/android/content_view_core_impl.cc

Index: content/browser/android/content_view_core_impl.cc
diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc
index bc68d1897a740f9736db19f3b90ad314eab719c3..43e8de712e4fc0053dcd4eac870d7231f16d6e44 100644
--- a/content/browser/android/content_view_core_impl.cc
+++ b/content/browser/android/content_view_core_impl.cc
@@ -541,9 +541,9 @@ void ContentViewCoreImpl::OnGestureEventAck(const blink::WebGestureEvent& event,
 
 bool ContentViewCoreImpl::FilterInputEvent(const blink::WebInputEvent& event) {
   if (event.GetType() != WebInputEvent::kGestureTap &&
-      event.GetType() != WebInputEvent::kGestureDoubleTap &&
       event.GetType() != WebInputEvent::kGestureLongTap &&
-      event.GetType() != WebInputEvent::kGestureLongPress)
+      event.GetType() != WebInputEvent::kGestureLongPress &&
+      event.GetType() != WebInputEvent::kMouseDown)
     return false;
 
   JNIEnv* env = AttachCurrentThread();
@@ -551,6 +551,11 @@ bool ContentViewCoreImpl::FilterInputEvent(const blink::WebInputEvent& event) {
   if (j_obj.is_null())
     return false;
 
+  Java_ContentViewCore_requestFocus(env, j_obj);

[aelias_OOO_until_Jul13, 2017/06/13 22:22:55]

This doesn't really have anything to do with filtering at all, it was just a
convenient place to apply a side effect, so we should move it somewhere better. 
I suggest applying the focus change inside EventForwarder.onTouchEvent and
EventForwarder.onMouseEvent instead.  The container view is not available from
there, so you can add it in as an additional argument to those methods similarly
to what is already done for onDragEvent.

(There's further cleanup possible here but it will be easier when PopupZoomer is
deleted, so we can go with this for now.)

[aelias_OOO_until_Jul13, 2017/06/15 22:14:30]

OK, Pedro explained offline this approach doesn't work with long-press, so lgtm
as is.

+
+  if (event.GetType() == WebInputEvent::kMouseDown)
+    return false;
+
   const blink::WebGestureEvent& gesture =
       static_cast<const blink::WebGestureEvent&>(event);
   int gesture_type = ToGestureEventType(event.GetType());