Fixing mouse focus on WebView

content/browser/android/content_view_core_impl.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/android/content_view_core_impl.h"
 
 #include <stddef.h>
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_array.h"
@@ skipping 523 matching lines @@
       if (ack_result == INPUT_EVENT_ACK_STATE_CONSUMED)
         Java_ContentViewCore_performLongPressHapticFeedback(env, j_obj);
       break;
     default:
       break;
   }
 }
 
 bool ContentViewCoreImpl::FilterInputEvent(const blink::WebInputEvent& event) {
   if (event.GetType() != WebInputEvent::kGestureTap &&
-      event.GetType() != WebInputEvent::kGestureDoubleTap &&
       event.GetType() != WebInputEvent::kGestureLongTap &&
-      event.GetType() != WebInputEvent::kGestureLongPress)
+      event.GetType() != WebInputEvent::kGestureLongPress &&
+      event.GetType() != WebInputEvent::kMouseDown)
     return false;
 
   JNIEnv* env = AttachCurrentThread();
   ScopedJavaLocalRef<jobject> j_obj = java_ref_.get(env);
   if (j_obj.is_null())
     return false;
 
+  Java_ContentViewCore_requestFocus(env, j_obj);

[aelias_OOO_until_Jul13, 2017/06/13 22:22:55]

This doesn't really have anything to do with filtering at all, it was just a
convenient place to apply a side effect, so we should move it somewhere better. 
I suggest applying the focus change inside EventForwarder.onTouchEvent and
EventForwarder.onMouseEvent instead.  The container view is not available from
there, so you can add it in as an additional argument to those methods similarly
to what is already done for onDragEvent.

(There's further cleanup possible here but it will be easier when PopupZoomer is
deleted, so we can go with this for now.)

[aelias_OOO_until_Jul13, 2017/06/15 22:14:30]

OK, Pedro explained offline this approach doesn't work with long-press, so lgtm
as is.

+
+  if (event.GetType() == WebInputEvent::kMouseDown)
+    return false;
+
   const blink::WebGestureEvent& gesture =
       static_cast<const blink::WebGestureEvent&>(event);
   int gesture_type = ToGestureEventType(event.GetType());
   return Java_ContentViewCore_filterTapOrPressEvent(env, j_obj, gesture_type,
                                                     gesture.x * dpi_scale(),
                                                     gesture.y * dpi_scale());
 }
 
 bool ContentViewCoreImpl::HasFocus() {
   JNIEnv* env = AttachCurrentThread();
@@ skipping 665 matching lines @@
     return ScopedJavaLocalRef<jobject>();
 
   return view->GetJavaObject();
 }
 
 bool RegisterContentViewCore(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace content