[Android WebAPK] Do not add padding to WebAPK primary icon

[Android WebAPK] Do not add padding to WebAPK primary icon

For non-intranet sites the WebAPK server ignores the icon sent as part of the
proto (but not the hash). This CL stops add_to_homescreen_data_fetcher.cc from
adding padding to the primary icon. This makes the icon in the add-to-homescreen
banner look the same as the one added to app list / homescreen by Google Play.

BUG=697228
Review-Url: https://codereview.chromium.org/2939773004
Cr-Commit-Position: refs/heads/master@{#479912}
Committed: https://chromium.googlesource.com/chromium/src/+/685bb7c7671afce49cda469ce95d303413cf3694

[pkotwicz, 2017-06-14 00:16:01]

pkotwicz@chromium.org changed reviewers:
+ hanxi@chromium.org

[pkotwicz, 2017-06-14 00:16:02]

Xi, can you please take a look? This CL depends on
https://codereview.chromium.org/2937823002/

[pkotwicz, 2017-06-14 00:28:04]

The goal of the CL is to make the behavior of add_to_homescreen_data_fetcher.cc
in this scenario less confusing:
- Page is WebAPK-compatible
- OnDataTimedout() is called after OnDidPerformInstallableCheck() but before
NotifyObserver()

[Xi Han, 2017-06-14 16:58:27]

lgtm

https://codereview.chromium.org/2939773004/diff/1/chrome/browser/android/weba...
File chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc (right):

https://codereview.chromium.org/2939773004/diff/1/chrome/browser/android/weba...
chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc:250: }
New line here:)

[pkotwicz, 2017-06-15 02:38:28]

Patchset #2 (id:20001) has been deleted

[pkotwicz, 2017-06-15 02:38:50]

pkotwicz@chromium.org changed reviewers:
+ dominickn@chromium.org

[pkotwicz, 2017-06-15 02:38:50]

Dominick, can you please take a look?

[dominickn, 2017-06-15 03:01:27]

https://codereview.chromium.org/2939773004/diff/40001/chrome/browser/android/...
File chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc (right):

https://codereview.chromium.org/2939773004/diff/40001/chrome/browser/android/...
chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc:247: if
(webapk_compatible) {
The multiple returns here are a bit strange. Can we do:

if (webak_compatible)
  NotifyObserver(*data.primary_icon)
else
  CreateLauncherIcon(*data.primary_icon)
return;

[pkotwicz, 2017-06-15 03:53:41]

Dominick, can you please take another look? I addressed your  (one and only)
comment :)

[dominickn, 2017-06-15 03:55:29]

lgtm, thanks

[pkotwicz, 2017-06-15 22:22:21]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2017-06-15 22:22:21]

The patchset sent to the CQ was uploaded after l-g-t-m from hanxi@chromium.org,
dominickn@chromium.org
Link to the patchset: https://codereview.chromium.org/2939773004/#ps80001
(title: "Merge branch 'master' into reenable_tests0000000000")

[commit-bot: I haz the power, 2017-06-15 22:22:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 01:58:03]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1497565341414180,
"parent_rev": "74d0043dcec7f193d4a1c006a34660041fde7b5c", "commit_rev":
"685bb7c7671afce49cda469ce95d303413cf3694"}

[commit-bot: I haz the power, 2017-06-16 01:58:13]

Description was changed from

==========
[Android WebAPK] Do not add padding to WebAPK primary icon

For non-intranet sites the WebAPK server ignores the icon sent as part of the
proto (but not the hash). This CL stops add_to_homescreen_data_fetcher.cc from
adding padding to the primary icon. This makes the icon in the add-to-homescreen
banner look the same as the one added to app list / homescreen by Google Play.

BUG=697228
==========

to

==========
[Android WebAPK] Do not add padding to WebAPK primary icon

For non-intranet sites the WebAPK server ignores the icon sent as part of the
proto (but not the hash). This CL stops add_to_homescreen_data_fetcher.cc from
adding padding to the primary icon. This makes the icon in the add-to-homescreen
banner look the same as the one added to app list / homescreen by Google Play.

BUG=697228

Review-Url: https://codereview.chromium.org/2939773004
Cr-Commit-Position: refs/heads/master@{#479912}
Committed:
https://chromium.googlesource.com/chromium/src/+/685bb7c7671afce49cda469ce95d...
==========

[commit-bot: I haz the power, 2017-06-16 01:58:15]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/685bb7c7671afce49cda469ce95d...