Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2939773003: Initialize dart-lang/tuple with the tuple package at v1.0.1. (Closed)

Created:
3 years, 6 months ago by jcollins
Modified:
3 years, 6 months ago
Reviewers:
devoncarew, Bill Hesse
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Initialize dart-lang/tuple with the tuple package at v1.0.1. --- Update README.google. Merge tag 'v1.0.1' of ../tuple-orig Merge pull request #2 from nex3/strong Fix all strong-mode warnings and errors Fix all strong-mode warnings and errors. Setup Travis CI. Update CHANGELOG.md and bump the version to 1.0.0. Remove _hash function and use hash functions provided by quiver_hashcode. Merge pull request #1 from srawlins/complete-changelog Complete changelog Complete changelog Bump the version to 0.4.0. Add CHANGELOG.md. Add fromList factory constructor. Add me to AUTHROS. Add Tuple6 and Tuple7 classes. Bump the version to 0.3.0. Add toList() to tuple classes. Add .pub and doc to .gitignore. Add API documentation to tuple classes. Bump the version to 0.2.0. Redesign the tuple API. * Rename PersistentTuple to Tuple and remove mutable tuple classes. * Rename iN to itemN. * Rename setIN to withItemN. Bump the version to 0.1.2. * Add me as an author. * Change homepage to https://github.com/kseo/tuple. Add test cases for tuple. Fix a bug in == operator of PersistentTuple classes. Check if o is of PersistentTuple type, not Tuple. 0.1.1 Merge pull request #3 from kseo/mapkey Override operator == and hashCode. Merge pull request #2 from kseo/addoverride Add @override annotation to toString(). Merge pull request #1 from kseo/gitignore Add .packages file to .gitignore. Add @override annotation to toString(). Add .packages file to .gitignore. As of 1.12, the .packages file exists after running pub get. Don’t check it into source control. Override operator == and hashCode. This makes it possible to use tuples as keys in maps. Initial commit BUG= R=devoncarew@google.com, whesse@google.com Committed: 311778bbbad6b78ac98bf00e5835edb75db178e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+746 lines, -3 lines) Patch
A .analysis_options View 1 chunk +2 lines, -0 lines 0 comments Download
A .gitignore View 1 chunk +28 lines, -0 lines 0 comments Download
A .travis.yml View 1 chunk +8 lines, -0 lines 0 comments Download
A AUTHORS View 1 chunk +8 lines, -0 lines 0 comments Download
A CHANGELOG.md View 1 chunk +27 lines, -0 lines 0 comments Download
A LICENSE View 1 chunk +22 lines, -0 lines 0 comments Download
M README.google View 1 chunk +4 lines, -3 lines 0 comments Download
A README.md View 1 chunk +21 lines, -0 lines 0 comments Download
A lib/src/tuple.dart View 1 chunk +481 lines, -0 lines 0 comments Download
A lib/tuple.dart View 1 chunk +27 lines, -0 lines 0 comments Download
A pubspec.yaml View 1 chunk +13 lines, -0 lines 0 comments Download
A test/all_tests.dart View 1 chunk +11 lines, -0 lines 0 comments Download
A test/tuple_test.dart View 1 chunk +66 lines, -0 lines 0 comments Download
A tool/travis.sh View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
jcollins
3 years, 6 months ago (2017-06-13 20:04:09 UTC) #2
jcollins
I've reviewed this code and it LGTM.
3 years, 6 months ago (2017-06-13 20:08:04 UTC) #3
devoncarew
lgtm lgtm for my part, but Bill should sign off given the repo forking process ...
3 years, 6 months ago (2017-06-13 20:57:39 UTC) #4
Bill Hesse
lgtm
3 years, 6 months ago (2017-06-14 09:30:46 UTC) #5
Bill Hesse
The references to ricow@ in the Wiki "Adding Dependencies" document are outdated, so he doesn't ...
3 years, 6 months ago (2017-06-14 10:59:38 UTC) #6
jcollins
3 years, 6 months ago (2017-06-15 14:47:04 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
311778bbbad6b78ac98bf00e5835edb75db178e0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698