Upgrade dartdoc to v0.12.0.

Upgrade dartdoc to v0.12.0.

Tested manually, can generate SDK and package docs not withstanding https://github.com/dart-lang/dartdoc/issues/1448. All unit tests except the integration test pass (comment docs have changed for some SDK libraries since 0.12.0).

BUG=
R=devoncarew@google.com, whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/14bbfa232118fcf60172a113c180c0954e753739

[jcollins, 2017-06-01 18:11:42]

Description was changed from

==========
Upgrade dartdoc to v0.12.0.  Tested manually, can generate SDK and
package docs.  All unit tests except the integration test pass (comment
docs have changed for some SDK libraries since 0.12.0).

BUG=
==========

to

==========
Upgrade dartdoc to v0.12.0.  Tested manually, can generate SDK and
package docs not withstanding https://github.com/dart-lang/dartdoc/issues/1448.
All unit tests except the integration test pass (comment docs have changed for
some SDK libraries since 0.12.0).

BUG=
==========

[jcollins, 2017-06-01 18:11:42]

jcollins@google.com changed reviewers:
+ devoncarew@google.com, whesse@google.com

[jcollins, 2017-06-01 18:12:00]

Description was changed from

==========
Upgrade dartdoc to v0.12.0.  Tested manually, can generate SDK and
package docs not withstanding https://github.com/dart-lang/dartdoc/issues/1448.
All unit tests except the integration test pass (comment docs have changed for
some SDK libraries since 0.12.0).

BUG=
==========

to

==========
Upgrade dartdoc to v0.12.0.

Tested manually, can generate SDK and package docs not withstanding
https://github.com/dart-lang/dartdoc/issues/1448. All unit tests except the
integration test pass (comment docs have changed for some SDK libraries since
0.12.0).

BUG=
==========

[devoncarew, 2017-06-02 21:08:56]

Sorry for the delay! Just seeing this review now; two questions about the deps
changes

https://codereview.chromium.org/2919823002/diff/1/.packages
File .packages (right):

https://codereview.chromium.org/2919823002/diff/1/.packages#newcode79
.packages:79: quiver_hashcode:third_party/pkg/quiver_hashcode/lib
Do we need this dep in dartdoc? How hard would it be to work around not having
it?

https://codereview.chromium.org/2919823002/diff/1/DEPS
File DEPS (right):

https://codereview.chromium.org/2919823002/diff/1/DEPS#newcode86
DEPS:86: "mustache4dart_tag" : "@1d2c49a6b0840132f880880af4bb2b1f519c6f66",
Is there a published version tag that would work for us?

[jcollins, 2017-06-02 21:10:44]

Please review.

[jcollins, 2017-06-05 20:20:14]

On 2017/06/02 21:08:56, devoncarew wrote:
> Sorry for the delay! Just seeing this review now; two questions about the deps
> changes
> 
> https://codereview.chromium.org/2919823002/diff/1/.packages
> File .packages (right):
> 
> https://codereview.chromium.org/2919823002/diff/1/.packages#newcode79
> .packages:79: quiver_hashcode:third_party/pkg/quiver_hashcode/lib
> Do we need this dep in dartdoc? How hard would it be to work around not having
> it?

(discussed offline, transitive dep of tuple)

> 
> https://codereview.chromium.org/2919823002/diff/1/DEPS
> File DEPS (right):
> 
> https://codereview.chromium.org/2919823002/diff/1/DEPS#newcode86
> DEPS:86: "mustache4dart_tag" : "@1d2c49a6b0840132f880880af4bb2b1f519c6f66",
> Is there a published version tag that would work for us?

There is now, with a fix to https://github.com/valotas/mustache4dart/issues/60. 
Changed.

PTAL

[devoncarew, 2017-06-05 20:29:39]

lgtm

[Bill Hesse, 2017-06-05 21:49:29]

Do the new packages meet the requirements set forth in
https://github.com/dart-lang/sdk/wiki/Adding-and-Updating-Dependencies ?

Have you added licence.GOOGLE files?
Can you avoid adding external dependencies by implementing the needed
functionality yourself?

Note that to include these libraries you need to do a complete code review of
all the code in them, probably with a second-party LGTM, and then check a copy
of them into our repo, which may be more work than you want to do.

[Bill Hesse, 2017-06-05 21:57:45]

Note that the quiver ahshcode package you are importing is already part of
quiver-dart, which is already imported into third_party.
https://github.com/google/quiver-dart/blob/master/lib/src/core/hash.dart


You should probably make a derived version of the tuple package, since you need
to copy and review it into our repo anyways, that uses the hash from the package
we already have - the file is identical.

[jcollins, 2017-06-15 17:34:43]

On 2017/06/05 21:57:45, Bill Hesse wrote:
> Note that the quiver ahshcode package you are importing is already part of
> quiver-dart, which is already imported into third_party.
> https://github.com/google/quiver-dart/blob/master/lib/src/core/hash.dart
> 
> 
> You should probably make a derived version of the tuple package, since you
need
> to copy and review it into our repo anyways, that uses the hash from the
package
> we already have - the file is identical.

This CL has been updated to use the new dart-lang version of the tuple package. 
A generated dartdoc from this CL passes smoke tests.

[Bill Hesse, 2017-06-16 07:47:43]

LGTM.

https://codereview.chromium.org/2919823002/diff/40001/.packages
File .packages (right):

https://codereview.chromium.org/2919823002/diff/40001/.packages#newcode79
.packages:79: quiver_hashcode:third_party/pkg/quiver_hashcode/lib
This line is no longer needed.

[jcollins, 2017-06-16 14:51:22]

Description was changed from

==========
Upgrade dartdoc to v0.12.0.

Tested manually, can generate SDK and package docs not withstanding
https://github.com/dart-lang/dartdoc/issues/1448. All unit tests except the
integration test pass (comment docs have changed for some SDK libraries since
0.12.0).

BUG=
==========

to

==========
Upgrade dartdoc to v0.12.0.

Tested manually, can generate SDK and package docs not withstanding
https://github.com/dart-lang/dartdoc/issues/1448. All unit tests except the
integration test pass (comment docs have changed for some SDK libraries since
0.12.0).

BUG=
R=devoncarew@google.com, whesse@google.com

Committed:
https://github.com/dart-lang/sdk/commit/14bbfa232118fcf60172a113c180c0954e753739
==========

[jcollins, 2017-06-16 14:51:23]

Committed patchset #3 (id:40001) manually as
14bbfa232118fcf60172a113c180c0954e753739 (presubmit successful).

[zra, 2017-06-19 18:22:31]

On 2017/06/16 14:51:23, jcollins wrote:
> Committed patchset #3 (id:40001) manually as
> 14bbfa232118fcf60172a113c180c0954e753739 (presubmit successful).

Is there a github issue to track pulling the tuple package from a mirror instead
of from github? If not, could you please file one and CC me?