Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2939753002:
Fix EditingTest.RichText* (Closed)
|
Created:
3 years, 6 months ago by David Tseng Modified:
3 years, 6 months ago Reviewers:
dmazzoni CC:
aboxhall+watch_chromium.org, alemate+watch_chromium.org, aleventhal+watch_chromium.org, arv+watch_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dougt+watch_chromium.org, dtseng+watch_chromium.org, je_julie, nektar+watch_chromium.org, oshima+watch_chromium.org, yuzo+watch_chromium.org, DaleCurtis Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix EditingTest.RichText*
BUG=724847, 731825, 732000
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2939753002
Cr-Commit-Position: refs/heads/master@{#479282}
Committed: https://chromium.googlesource.com/chromium/src/+/7b2d9fd6510ad34f7530a616586a93c68eb0b10e
Patch Set 1 #Patch Set 2 : Rebase. #Messages
Total messages: 22 (16 generated)
Description was changed from ========== Fix EditingTest.RichText* BUG= ========== to ========== Fix EditingTest.RichText* BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dtseng@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix EditingTest.RichText* BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Fix EditingTest.RichText* BUG=724847,731825,732000 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
dtseng@chromium.org changed reviewers: + dalecurtis@chromium.org
Sorry, I'm not a good reviewer for this. Can you have someone from your team review?
dtseng@chromium.org changed reviewers: + dmazzoni@chromium.org - dalecurtis@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by dtseng@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dtseng@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dmazzoni@chromium.org Link to the patchset: https://codereview.chromium.org/2939753002/#ps20001 (title: "Rebase.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497413622276770,
"parent_rev": "72d438c82f2139401a3af46c54a6f6a91be329e0", "commit_rev":
"7b2d9fd6510ad34f7530a616586a93c68eb0b10e"}
Message was sent while issue was closed.
Description was changed from ========== Fix EditingTest.RichText* BUG=724847,731825,732000 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Fix EditingTest.RichText* BUG=724847,731825,732000 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2939753002 Cr-Commit-Position: refs/heads/master@{#479282} Committed: https://chromium.googlesource.com/chromium/src/+/7b2d9fd6510ad34f7530a616586a... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/7b2d9fd6510ad34f7530a616586a... |
