Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 2939723003: Allow 3 lines for suggestion headers when summaries are not shown. (Closed)

Created:
3 years, 6 months ago by Michael van Ouwerkerk
Modified:
3 years, 6 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow 3 lines for suggestion headers when summaries are not shown. BUG=731605 Review-Url: https://codereview.chromium.org/2939723003 Cr-Commit-Position: refs/heads/master@{#479153} Committed: https://chromium.googlesource.com/chromium/src/+/2a64e2319ac7fdc7a7a856c797fa2565656e92dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M chrome/android/java/res/layout/new_tab_page_snippets_card.xml View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetArticleViewHolder.java View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
Michael van Ouwerkerk
Bernhard, could you take a look please?
3 years, 6 months ago (2017-06-13 16:17:29 UTC) #4
Bernhard Bauer
lgtm
3 years, 6 months ago (2017-06-13 16:18:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939723003/1
3 years, 6 months ago (2017-06-13 16:21:03 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/198836) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 6 months ago (2017-06-13 17:07:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939723003/1
3 years, 6 months ago (2017-06-13 17:10:11 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/198848) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 6 months ago (2017-06-13 17:17:37 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939723003/1
3 years, 6 months ago (2017-06-13 20:31:02 UTC) #16
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 21:19:28 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2a64e2319ac7fdc7a7a856c797fa...

Powered by Google App Engine
This is Rietveld 408576698