Source/bindings/v8/V8NPUtils.cpp - Issue 293963003: Remove ScriptObject

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8NPUtils.cpp

Issue 293963003: Remove ScriptObject (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8NPUtils.cpp

diff --git a/Source/bindings/v8/V8NPUtils.cpp b/Source/bindings/v8/V8NPUtils.cpp

index cba26ebcd08dd23991c6f077d93462b9f2354af7..2cbe3ef91772c92e75d6f4584c37ea72d161b03a 100644

--- a/Source/bindings/v8/V8NPUtils.cpp

+++ b/Source/bindings/v8/V8NPUtils.cpp

@@ -70,7 +70,7 @@ void convertV8ObjectToNPVariant(v8::Local<v8::Value> object, NPObject* owner, NP

STRINGN_TO_NPVARIANT(utf8Chars, length-1, *result);

} else if (object->IsObject()) {

DOMWindow* window = currentDOMWindow(isolate);

- NPObject* npobject = npCreateV8ScriptObject(0, v8::Handle<v8::Object>::Cast(object), window, isolate);

+ NPObject* npobject = npCreateV8ScriptValue(0, v8::Handle<v8::Object>::Cast(object), window, isolate);

if (npobject)

_NPN_RegisterObject(npobject, owner);

OBJECT_TO_NPVARIANT(npobject, *result);