Source/bindings/v8/NPV8Object.cpp - Issue 293963003: Remove ScriptObject

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/NPV8Object.cpp

Issue 293963003: Remove ScriptObject (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/NPV8Object.cpp

diff --git a/Source/bindings/v8/NPV8Object.cpp b/Source/bindings/v8/NPV8Object.cpp

index 1c432fe8839e4be934a40e8786b1d78d94b2ab83..1969369a5e4157ff46332257dd3f841920c73f70 100644

--- a/Source/bindings/v8/NPV8Object.cpp

+++ b/Source/bindings/v8/NPV8Object.cpp

@@ -114,7 +114,7 @@ NPObject* v8ObjectToNPObject(v8::Handle<v8::Object> object)

return reinterpret_cast<NPObject*>(object->GetAlignedPointerFromInternalField(v8DOMWrapperObjectIndex));

}

-NPObject* npCreateV8ScriptObject(NPP npp, v8::Handle<v8::Object> object, DOMWindow* root, v8::Isolate* isolate)

+NPObject* npCreateV8ScriptValue(NPP npp, v8::Handle<v8::Object> object, DOMWindow* root, v8::Isolate* isolate)

{

// Check to see if this object is already wrapped.

if (object->InternalFieldCount() == npObjectInternalFieldCount) {