Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: Source/core/inspector/PromiseTracker.h

Issue 293963003: Remove ScriptObject (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorInstrumentation.idl ('k') | Source/core/inspector/PromiseTracker.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/PromiseTracker.h
diff --git a/Source/core/inspector/PromiseTracker.h b/Source/core/inspector/PromiseTracker.h
index 150930d7e361dfd1b5df6a8e47963ffecfa714c1..5b54d6772f81da4c5d3f1c65108f00ee16b34d8a 100644
--- a/Source/core/inspector/PromiseTracker.h
+++ b/Source/core/inspector/PromiseTracker.h
@@ -31,8 +31,8 @@
#ifndef PromiseTracker_h
#define PromiseTracker_h
+#include "bindings/v8/ScriptValue.h"
aandrey 2014/05/20 15:51:41 FYI this file and few more were removed in https:/
#include "bindings/v8/custom/V8PromiseCustom.h"
-#include "bindings/v8/ScriptObjectTraits.h"
#include "core/inspector/ScriptCallStack.h"
#include "wtf/HashMap.h"
#include "wtf/Noncopyable.h"
@@ -53,19 +53,19 @@ public:
void clear();
- void didCreatePromise(const ScriptObject& promise);
- void didUpdatePromiseParent(const ScriptObject& promise, const ScriptObject& parentPromise);
- void didUpdatePromiseState(const ScriptObject& promise, V8PromiseCustom::PromiseState, const ScriptValue& result);
+ void didCreatePromise(const ScriptValue& promise);
+ void didUpdatePromiseParent(const ScriptValue& promise, const ScriptValue& parentPromise);
+ void didUpdatePromiseState(const ScriptValue& promise, V8PromiseCustom::PromiseState, const ScriptValue& result);
private:
class PromiseData : public RefCounted<PromiseData> {
public:
- PromiseData(const ScriptObject& promise, const ScriptObject& parentPromise, const ScriptValue& result, V8PromiseCustom::PromiseState state, double timestamp);
+ PromiseData(const ScriptValue& promise, const ScriptValue& parentPromise, const ScriptValue& result, V8PromiseCustom::PromiseState, double timestamp);
void didSettlePromise(double timestamp);
- ScriptObject m_promise;
- ScriptObject m_parentPromise;
+ ScriptValue m_promise;
+ ScriptValue m_parentPromise;
ScriptValue m_result;
V8PromiseCustom::PromiseState m_state;
@@ -78,7 +78,7 @@ private:
};
bool m_isEnabled;
- typedef HashMap<ScriptObject, RefPtr<PromiseData>, ScriptObjectHash, ScriptObjectHashTraits> PromiseDataMap;
+ typedef HashMap<ScriptValue, RefPtr<PromiseData>, ScriptValueHash, ScriptValueHashTraits> PromiseDataMap;
PromiseDataMap m_promiseDataMap;
};
« no previous file with comments | « Source/core/inspector/InspectorInstrumentation.idl ('k') | Source/core/inspector/PromiseTracker.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698