Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2939623002: [DONT COMMIT] WIP: WorkerClientsInitializer (Closed)

Created:
3 years, 6 months ago by nhiroki
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews, shimazu+worker_chromium.org, haraken, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org, platform-architecture-syd+reviews-web_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Worker: Introduce a unified way to provide module clients to WorkerClients As a code cleanup, this CL introduces WorkletClientsInitializer that enabled to provide module clients (in modules/) to WorkerClients (in core/workers/) for various workers in a unified way. BUG=729500

Patch Set 1 #

Patch Set 2 : WIP #

Patch Set 3 : tzik-san #

Patch Set 4 : WIP #

Patch Set 5 : WIP #

Patch Set 6 : WIP #

Patch Set 7 : EXPORT #

Patch Set 8 : rebase #

Patch Set 9 : fix #

Patch Set 10 : rebase #

Patch Set 11 : CORE_EXPORT #

Patch Set 12 : in header #

Patch Set 13 : WIP #

Patch Set 14 : wip #

Patch Set 15 : rebase #

Patch Set 16 : DISALLOW_COPY_AND_ASSIGN and static_assert #

Patch Set 17 : instantiation #

Patch Set 18 : fix?? #

Patch Set 19 : try #

Patch Set 20 : try2 #

Patch Set 21 : SUCCESS!! #

Patch Set 22 : remove #

Patch Set 23 : try! #

Patch Set 24 : try! (CORE_EXPORT -> MODULES_EXPORT) #

Patch Set 25 : CORE_EXTERN_TEMPLACE_EXPORT / CORE_TEMPLATE_EXPORT #

Patch Set 26 : finalize #

Patch Set 27 : finalize2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -333 lines) Patch
M third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 5 chunks +8 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 4 chunks +4 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/workers/BUILD.gn View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxyProvider.h View 1 chunk +0 lines, -67 lines 0 comments Download
D third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxyProvider.cpp View 1 chunk +0 lines, -58 lines 0 comments Download
M third_party/WebKit/Source/core/workers/Worker.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/workers/Worker.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 2 chunks +15 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerClients.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 2 chunks +57 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/ModulesInitializer.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 4 chunks +21 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 3 chunks +8 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 21 22 23 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/web/DedicatedWorkerMessagingProxyProviderImpl.h View 1 chunk +0 lines, -64 lines 0 comments Download
D third_party/WebKit/Source/web/DedicatedWorkerMessagingProxyProviderImpl.cpp View 1 chunk +0 lines, -79 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/public/web/WebEmbeddedWorker.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 26 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/public/web/WebSharedWorker.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 26 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 88 (88 generated)
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-13 07:38:44 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939623002/80001
3 years, 6 months ago (2017-06-13 07:38:51 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-13 07:41:00 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/440180) mac_chromium_rel_ng on ...
3 years, 6 months ago (2017-06-13 07:41:01 UTC) #4
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-13 07:48:58 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939623002/100001
3 years, 6 months ago (2017-06-13 07:49:13 UTC) #6
nhiroki
Description was changed from ========== WIP: WorkerClientsInitializer BUG= ========== to ========== Worker: Introduce a common ...
3 years, 6 months ago (2017-06-13 07:52:14 UTC) #7
nhiroki
Description was changed from ========== Worker: Introduce a common mechanism to provide module clients to ...
3 years, 6 months ago (2017-06-13 07:54:53 UTC) #8
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-13 07:56:48 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939623002/100001
3 years, 6 months ago (2017-06-13 07:56:57 UTC) #10
nhiroki
Description was changed from ========== Worker: Introduce a common mechanism to provide module clients to ...
3 years, 6 months ago (2017-06-13 08:02:18 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-13 09:52:32 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/432552)
3 years, 6 months ago (2017-06-13 09:52:33 UTC) #13
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-13 14:14:10 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939623002/120001
3 years, 6 months ago (2017-06-13 14:14:29 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-13 14:16:46 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/230767) ios-simulator-xcode-clang on ...
3 years, 6 months ago (2017-06-13 14:16:49 UTC) #17
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-13 14:19:26 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939623002/140001
3 years, 6 months ago (2017-06-13 14:19:38 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-13 14:30:51 UTC) #20
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/388011) linux_chromium_headless_rel on ...
3 years, 6 months ago (2017-06-13 14:30:52 UTC) #21
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-13 21:15:58 UTC) #22
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939623002/160001
3 years, 6 months ago (2017-06-13 21:16:45 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-13 21:20:08 UTC) #24
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xcode-clang/builds/119787) mac_chromium_compile_dbg_ng on ...
3 years, 6 months ago (2017-06-13 21:20:10 UTC) #25
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-13 21:25:17 UTC) #26
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939623002/180001
3 years, 6 months ago (2017-06-13 21:26:05 UTC) #27
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-13 22:13:25 UTC) #28
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939623002/200001
3 years, 6 months ago (2017-06-13 22:14:10 UTC) #29
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-13 22:40:09 UTC) #30
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939623002/220001
3 years, 6 months ago (2017-06-13 22:40:29 UTC) #31
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-13 23:35:43 UTC) #32
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/449031)
3 years, 6 months ago (2017-06-13 23:35:44 UTC) #33
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-13 23:42:50 UTC) #34
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939623002/240001
3 years, 6 months ago (2017-06-13 23:43:17 UTC) #35
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-14 00:21:32 UTC) #36
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939623002/260001
3 years, 6 months ago (2017-06-14 00:22:00 UTC) #37
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-14 00:25:03 UTC) #38
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/236948) mac_chromium_compile_dbg_ng on ...
3 years, 6 months ago (2017-06-14 00:25:06 UTC) #39
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-14 01:04:40 UTC) #40
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939623002/280001
3 years, 6 months ago (2017-06-14 01:05:12 UTC) #41
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-14 01:59:01 UTC) #42
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/433412)
3 years, 6 months ago (2017-06-14 01:59:02 UTC) #43
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-14 08:26:04 UTC) #44
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939623002/290001
3 years, 6 months ago (2017-06-14 08:26:17 UTC) #45
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-14 08:48:45 UTC) #46
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939623002/310001
3 years, 6 months ago (2017-06-14 08:48:54 UTC) #47
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-14 09:44:02 UTC) #48
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/433654)
3 years, 6 months ago (2017-06-14 09:44:04 UTC) #49
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-14 10:05:28 UTC) #50
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939623002/330001
3 years, 6 months ago (2017-06-14 10:07:07 UTC) #51
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-14 10:57:33 UTC) #52
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939623002/330001
3 years, 6 months ago (2017-06-14 10:57:40 UTC) #53
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-14 12:27:49 UTC) #54
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/433707)
3 years, 6 months ago (2017-06-14 12:27:50 UTC) #55
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-14 13:49:18 UTC) #56
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939623002/330001
3 years, 6 months ago (2017-06-14 13:49:33 UTC) #57
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-14 13:59:43 UTC) #58
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939623002/330001
3 years, 6 months ago (2017-06-14 13:59:52 UTC) #59
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-14 15:53:50 UTC) #60
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/433855)
3 years, 6 months ago (2017-06-14 15:53:51 UTC) #61
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-15 08:13:30 UTC) #62
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939623002/350001
3 years, 6 months ago (2017-06-15 08:13:47 UTC) #63
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-15 09:06:15 UTC) #64
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/250590)
3 years, 6 months ago (2017-06-15 09:06:16 UTC) #65
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-15 13:03:29 UTC) #66
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939623002/370001
3 years, 6 months ago (2017-06-15 13:03:43 UTC) #67
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-15 13:58:17 UTC) #68
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/318236)
3 years, 6 months ago (2017-06-15 13:58:18 UTC) #69
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-16 01:28:21 UTC) #70
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939623002/390001
3 years, 6 months ago (2017-06-16 01:28:43 UTC) #71
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-16 03:13:31 UTC) #72
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 6 months ago (2017-06-16 03:13:33 UTC) #73
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-16 03:40:14 UTC) #74
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939623002/410001
3 years, 6 months ago (2017-06-16 03:40:35 UTC) #75
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-16 03:54:15 UTC) #76
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939623002/430001
3 years, 6 months ago (2017-06-16 03:54:26 UTC) #77
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-16 03:58:02 UTC) #78
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939623002/450001
3 years, 6 months ago (2017-06-16 03:58:14 UTC) #79
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-16 05:06:32 UTC) #80
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939623002/470001
3 years, 6 months ago (2017-06-16 05:06:54 UTC) #81
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-16 06:00:01 UTC) #82
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939623002/490001
3 years, 6 months ago (2017-06-16 06:00:28 UTC) #83
nhiroki
The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run
3 years, 6 months ago (2017-06-16 06:57:26 UTC) #84
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939623002/510001
3 years, 6 months ago (2017-06-16 06:57:41 UTC) #85
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago (2017-06-16 07:49:29 UTC) #86
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/469520)
3 years, 6 months ago (2017-06-16 07:49:30 UTC) #87
nhiroki
3 years, 6 months ago (2017-06-20 03:14:21 UTC) #88 
Description was changed from

==========
Worker: Introduce a unified way to provide module clients to WorkerClients

As a code cleanup, this CL introduces WorkletClientsInitializer that enabled to
provide module clients (in modules/) to WorkerClients (in core/workers/) for
various workers in a unified way.

BUG=729500
==========

to

==========
Worker: Introduce a unified way to provide module clients to WorkerClients

As a code cleanup, this CL introduces WorkletClientsInitializer that enabled to
provide module clients (in modules/) to WorkerClients (in core/workers/) for
various workers in a unified way.

BUG=729500
==========

Powered by Google App Engine
This is Rietveld 408576698