In-declaration initialization for BrowserView member variables

In-declaration initialization for BrowserView member variables

This CL converts all member variable of the BrowserView class to use the 
in-declaration initialization where possible. The initialization was 
done in the BrowserView constructor.

BUG=732596
Review-Url: https://codereview.chromium.org/2939583002
Cr-Commit-Position: refs/heads/master@{#478862}
Committed: https://chromium.googlesource.com/chromium/src/+/a7ca2fe2926386d3a996a1e84d1a52e79c22996a

[chengx, 2017-06-12 23:54:28]

Description was changed from

==========
in-declaration initialization

BUG=
==========

to

==========
In-declaration initialization for BrowserView member variables

This CL converts all member variable of the BrowserView class to use the 
in-declaration initialization where possible. The initialization was 
done in the BrowserView constructor.

BUG=732596
==========

[chengx, 2017-06-12 23:54:28]

chengx@chromium.org changed reviewers:
+ pkasting@chromium.org

[chengx, 2017-06-12 23:54:32]

The CQ bit was checked by chengx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 23:54:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chengx, 2017-06-12 23:57:37]

Hi Peter, I've made this CL per request. PTAL, thanks!

[Peter Kasting, 2017-06-13 00:05:56]

LGTM

https://codereview.chromium.org/2939583002/diff/1/chrome/browser/ui/views/fra...
File chrome/browser/ui/views/frame/browser_view.h (right):

https://codereview.chromium.org/2939583002/diff/1/chrome/browser/ui/views/fra...
chrome/browser/ui/views/frame/browser_view.h:714: mutable
base::WeakPtrFactory<BrowserView> activate_modal_dialog_factory_;
Can probably init this here too using {}, a la
https://cs.chromium.org/chromium/src/chrome/browser/chromeos/settings/device_...
.

[chengx, 2017-06-13 00:16:40]

The CQ bit was checked by chengx@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 00:17:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 01:25:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-13 01:25:03]

Dry run: This issue passed the CQ dry run.

[chengx, 2017-06-13 01:49:05]

I've addressed the comment in the new patch set. Thanks!

https://codereview.chromium.org/2939583002/diff/1/chrome/browser/ui/views/fra...
File chrome/browser/ui/views/frame/browser_view.h (right):

https://codereview.chromium.org/2939583002/diff/1/chrome/browser/ui/views/fra...
chrome/browser/ui/views/frame/browser_view.h:714: mutable
base::WeakPtrFactory<BrowserView> activate_modal_dialog_factory_;
On 2017/06/13 00:05:56, Peter Kasting wrote:
> Can probably init this here too using {}, a la
>
https://cs.chromium.org/chromium/src/chrome/browser/chromeos/settings/device_...
> .

Done.

[chengx, 2017-06-13 01:49:13]

The CQ bit was checked by chengx@chromium.org

[chengx, 2017-06-13 01:49:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2939583002/#ps20001
(title: "More conversion")

[commit-bot: I haz the power, 2017-06-13 01:49:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 01:56:49]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497318553895070,
"parent_rev": "c196efb30c8553563fd577a15d3a0572c3d2a69e", "commit_rev":
"a7ca2fe2926386d3a996a1e84d1a52e79c22996a"}

[commit-bot: I haz the power, 2017-06-13 01:57:03]

Description was changed from

==========
In-declaration initialization for BrowserView member variables

This CL converts all member variable of the BrowserView class to use the 
in-declaration initialization where possible. The initialization was 
done in the BrowserView constructor.

BUG=732596
==========

to

==========
In-declaration initialization for BrowserView member variables

This CL converts all member variable of the BrowserView class to use the 
in-declaration initialization where possible. The initialization was 
done in the BrowserView constructor.

BUG=732596

Review-Url: https://codereview.chromium.org/2939583002
Cr-Commit-Position: refs/heads/master@{#478862}
Committed:
https://chromium.googlesource.com/chromium/src/+/a7ca2fe2926386d3a996a1e84d1a...
==========

[commit-bot: I haz the power, 2017-06-13 01:57:05]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a7ca2fe2926386d3a996a1e84d1a...