Omnibox UI Experiments: Add feature flags for 3 URL elision experiments.

Omnibox UI Experiments: Add feature flags for 3 URL elision experiments.

This CL contains just the feature flags. Implementation to follow
shortly.

BUG=732582
Review-Url: https://codereview.chromium.org/2939563002
Cr-Commit-Position: refs/heads/master@{#479215}
Committed: https://chromium.googlesource.com/chromium/src/+/fd4ba279668fa6d606f622e023fb8923aa8923c1

[tommycli, 2017-06-12 22:48:56]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-12 22:49:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 23:21:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-12 23:21:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tommycli, 2017-06-12 23:24:52]

Patchset #2 (id:20001) has been deleted

[tommycli, 2017-06-12 23:24:56]

Patchset #2 (id:40001) has been deleted

[tommycli, 2017-06-12 23:25:44]

tommycli@chromium.org changed reviewers:
+ jdonnelly@chromium.org

[tommycli, 2017-06-12 23:25:44]

jdonnelly: PTAL, this adds feature flags for the 3 URL elision experiments we
want to do, thanks!

[tommycli, 2017-06-13 20:44:16]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 20:44:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Justin Donnelly, 2017-06-13 20:58:12]

https://codereview.chromium.org/2939563002/diff/60001/chrome/browser/about_fl...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/2939563002/diff/60001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:3004:
flag_descriptions::kOmniboxUIHideSuggestionUrlSubdomainName,
"Hide subdomain" feels like it's over-specifying what this is intended to do. I
know it'll make the identifiers somewhat ridiculously long, but how about adding
"trivial" to these? For example,
kOmniboxUIHideSuggestionUrlTrivialSubdomainsName, etc.

https://codereview.chromium.org/2939563002/diff/60001/chrome/browser/flag_des...
File chrome/browser/flag_descriptions.cc (right):

https://codereview.chromium.org/2939563002/diff/60001/chrome/browser/flag_des...
chrome/browser/flag_descriptions.cc:3106: "Elides non-informative subdomains
from suggested URLs in the Omnibox "
How about "trivially informative" instead of "non-informative" to avoid nit
picking about how these *could* offer some information.

https://codereview.chromium.org/2939563002/diff/60001/chrome/browser/flag_des...
chrome/browser/flag_descriptions.cc:3107: "dropdown.";
Add "(for example, www. and m.)".

https://codereview.chromium.org/2939563002/diff/60001/components/omnibox/brow...
File components/omnibox/browser/omnibox_field_trial.cc (right):

https://codereview.chromium.org/2939563002/diff/60001/components/omnibox/brow...
components/omnibox/browser/omnibox_field_trial.cc:105: // This only hides some
special non-informative subdomains such as "www" or "m".
And then s/non-/trivially/ here.

[tommycli, 2017-06-13 21:44:17]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-13 21:45:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2017-06-13 21:47:09]

thanks!

https://codereview.chromium.org/2939563002/diff/60001/chrome/browser/about_fl...
File chrome/browser/about_flags.cc (right):

https://codereview.chromium.org/2939563002/diff/60001/chrome/browser/about_fl...
chrome/browser/about_flags.cc:3004:
flag_descriptions::kOmniboxUIHideSuggestionUrlSubdomainName,
On 2017/06/13 20:58:12, Justin Donnelly wrote:
> "Hide subdomain" feels like it's over-specifying what this is intended to do.
I
> know it'll make the identifiers somewhat ridiculously long, but how about
adding
> "trivial" to these? For example,
> kOmniboxUIHideSuggestionUrlTrivialSubdomainsName, etc.

Done.

https://codereview.chromium.org/2939563002/diff/60001/chrome/browser/flag_des...
File chrome/browser/flag_descriptions.cc (right):

https://codereview.chromium.org/2939563002/diff/60001/chrome/browser/flag_des...
chrome/browser/flag_descriptions.cc:3106: "Elides non-informative subdomains
from suggested URLs in the Omnibox "
On 2017/06/13 20:58:12, Justin Donnelly wrote:
> How about "trivially informative" instead of "non-informative" to avoid nit
> picking about how these *could* offer some information.

Done.

https://codereview.chromium.org/2939563002/diff/60001/chrome/browser/flag_des...
chrome/browser/flag_descriptions.cc:3107: "dropdown.";
On 2017/06/13 20:58:12, Justin Donnelly wrote:
> Add "(for example, www. and m.)".

Done.

https://codereview.chromium.org/2939563002/diff/60001/components/omnibox/brow...
File components/omnibox/browser/omnibox_field_trial.cc (right):

https://codereview.chromium.org/2939563002/diff/60001/components/omnibox/brow...
components/omnibox/browser/omnibox_field_trial.cc:105: // This only hides some
special non-informative subdomains such as "www" or "m".
On 2017/06/13 20:58:12, Justin Donnelly wrote:
> And then s/non-/trivially/ here.

Done.

[Justin Donnelly, 2017-06-13 21:51:30]

lgtm (but looks like histograms.xml slipped in to this CL by mistake?)

[tommycli, 2017-06-13 21:53:18]

On 2017/06/13 21:51:30, Justin Donnelly wrote:
> lgtm (but looks like histograms.xml slipped in to this CL by mistake?)

git cl format insisted on reformatting histograms.xml along with enums.xml. Not
sure why. I'll just roll with it since the reformatting is correct.

[tommycli, 2017-06-13 21:53:27]

On 2017/06/13 21:53:18, tommycli wrote:
> On 2017/06/13 21:51:30, Justin Donnelly wrote:
> > lgtm (but looks like histograms.xml slipped in to this CL by mistake?)
> 
> git cl format insisted on reformatting histograms.xml along with enums.xml.
Not
> sure why. I'll just roll with it since the reformatting is correct.

thanks!

[tommycli, 2017-06-13 21:53:32]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2017-06-13 21:54:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2017-06-13 22:37:18]

The CQ bit was unchecked by tommycli@chromium.org

[tommycli, 2017-06-13 22:55:23]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2017-06-13 22:55:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
jdonnelly@chromium.org
Link to the patchset: https://codereview.chromium.org/2939563002/#ps120001
(title: "Replace 'Protocol' with 'Scheme'")

[commit-bot: I haz the power, 2017-06-13 22:55:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-14 00:05:41]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1497394523258610,
"parent_rev": "3a26e05c70e63815c7c18284e5e006b9d0ac75af", "commit_rev":
"fd4ba279668fa6d606f622e023fb8923aa8923c1"}

[commit-bot: I haz the power, 2017-06-14 00:05:52]

Description was changed from

==========
Omnibox UI Experiments: Add feature flags for 3 URL elision experiments.

This CL contains just the feature flags. Implementation to follow
shortly.

BUG=732582
==========

to

==========
Omnibox UI Experiments: Add feature flags for 3 URL elision experiments.

This CL contains just the feature flags. Implementation to follow
shortly.

BUG=732582

Review-Url: https://codereview.chromium.org/2939563002
Cr-Commit-Position: refs/heads/master@{#479215}
Committed:
https://chromium.googlesource.com/chromium/src/+/fd4ba279668fa6d606f622e023fb...
==========

[commit-bot: I haz the power, 2017-06-14 00:05:53]

Committed patchset #5 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/fd4ba279668fa6d606f622e023fb...