Updated parser to produce error when trying to reinitialize final variables in class constructors. …

tests/language/final_attempt_reinitialization_test.dart

Index: tests/language/final_attempt_reinitialization_test.dart
diff --git a/tests/language/final_attempt_reinitialization_test.dart b/tests/language/final_attempt_reinitialization_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..c2c7f4d08c5467538ab62f7d0a2879706c12502b
--- /dev/null
+++ b/tests/language/final_attempt_reinitialization_test.dart
@@ -0,0 +1,20 @@
+// Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+class Foo {         //# 01: compile-time error
+  final int x = 42; //# 01: compile-time error
+  Foo(this.x);      //# 01: compile-time error
+}                   //# 01: compile-time error

[siva, 2017/06/13 22:37:57]

Not sure why you have so many 01: compile-time error specifications here

[bkonyi, 2017/06/15 22:32:48]

Oh, I was under the assumption that you needed those specifications for those
lines to be included for an instance of a multitest. Just putting the
specification by the calls in main does the trick as well.

+
+class CoffeeShop {                  //# 02: compile-time error
+  final String name = "Coffee Lab"; //# 02: compile-time error
+  CoffeeShop.name(String name) :    //# 02: compile-time error
+    this.name = name;               //# 02: compile-time error
+}                                   //# 02: compile-time error
+
+void main() {
+  Foo f = new Foo(10); //# 01: compile-time error
+  CoffeeShop presidentialCoffee =       //# 02: compile-time error
+    new CoffeeShop.name("Covfefe Lab"); //# 02: compile-time error
+}

[siva, 2017/06/13 22:37:57]

I think this should do the trick :


class Foo {
  final int x = 42;
  Foo(this.x);  // #01: compile-time error
  Foo.name(String name) : this.name = name; // 02: compile-time error
  final String name = "Coffee Lab";
}

void main() {
  Foo f1 = new Foo(10);
  Foo f2 = new Foo.name("Tea Lab");
}

[bkonyi, 2017/06/15 22:32:48]

Yes, that works too.