Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Side by Side Diff: tests/language/final_attempt_reinitialization_test.dart

Issue 2939553005: Updated parser to produce error when trying to reinitialize final variables in class constructors. … (Closed)
Patch Set: Added test, addressed comments Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« runtime/vm/parser.cc ('K') | « runtime/vm/parser.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file.
4
5 class Foo { //# 01: compile-time error
6 final int x = 42; //# 01: compile-time error
7 Foo(this.x); //# 01: compile-time error
8 } //# 01: compile-time error
siva 2017/06/13 22:37:57 Not sure why you have so many 01: compile-time err
bkonyi 2017/06/15 22:32:48 Oh, I was under the assumption that you needed tho
9
10 class CoffeeShop { //# 02: compile-time error
11 final String name = "Coffee Lab"; //# 02: compile-time error
12 CoffeeShop.name(String name) : //# 02: compile-time error
13 this.name = name; //# 02: compile-time error
14 } //# 02: compile-time error
15
16 void main() {
17 Foo f = new Foo(10); //# 01: compile-time error
18 CoffeeShop presidentialCoffee = //# 02: compile-time error
19 new CoffeeShop.name("Covfefe Lab"); //# 02: compile-time error
20 }
siva 2017/06/13 22:37:57 I think this should do the trick : class Foo {
bkonyi 2017/06/15 22:32:48 Yes, that works too.
OLDNEW
« runtime/vm/parser.cc ('K') | « runtime/vm/parser.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698