Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2939553002: Views; Fire a value changed event when the contents of a text field changes. (Closed)

Created:
3 years, 6 months ago by nektarios
Modified:
3 years, 6 months ago
Reviewers:
tapted, dmazzoni
CC:
chromium-reviews, nona+watch_chromium.org, James Su, shuchen+watch_chromium.org, yusukes+watch_chromium.org, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Views; Fire a value changed event when the contents of a text field changes. We are currently firing a text changed event which indicates that the name of the text field has changed, not its value. BUG=732570 R=dmazzoni@chromium.org, msw@chromium.org Review-Url: https://codereview.chromium.org/2939553002 Cr-Commit-Position: refs/heads/master@{#479711} Committed: https://chromium.googlesource.com/chromium/src/+/4855dac6c6f98f9f4792128dfafa246d23afd98d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/views/controls/textfield/textfield.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
nektarios
3 years, 6 months ago (2017-06-12 22:21:01 UTC) #1
dmazzoni
lgtm
3 years, 6 months ago (2017-06-15 05:56:26 UTC) #3
tapted
lgtm - thanks! sadly.. not enough to fix http://crbug.com/657884 - I'm still working on the ...
3 years, 6 months ago (2017-06-15 06:11:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939553002/1
3 years, 6 months ago (2017-06-15 14:28:57 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 15:27:56 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4855dac6c6f98f9f4792128dfafa...

Powered by Google App Engine
This is Rietveld 408576698