color-profile-layer-filter.html issue

color-profile-layer-filter.html issue

Illustration of bug and fix

BUG=730821
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2939513002
Cr-Commit-Position: refs/heads/master@{#478861}
Committed: https://chromium.googlesource.com/chromium/src/+/c196efb30c8553563fd577a15d3a0572c3d2a69e

[ccameron, 2017-06-12 19:54:54]

Description was changed from

==========
color-profile-layer-filter.html issue

Illustration of bug and fix

BUG=730821
==========

to

==========
color-profile-layer-filter.html issue

Illustration of bug and fix

BUG=730821
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ccameron, 2017-06-12 21:40:29]

ccameron@chromium.org changed reviewers:
+ enne@chromium.org

[ccameron, 2017-06-12 21:40:30]

This ended up being pretty simple ...

[enne (OOO), 2017-06-12 22:18:00]

lgtm

https://codereview.chromium.org/2939513002/diff/60001/cc/output/gl_renderer.cc
File cc/output/gl_renderer.cc (right):

https://codereview.chromium.org/2939513002/diff/60001/cc/output/gl_renderer.c...
cc/output/gl_renderer.cc:1286: // |params->color_space| was populated when
|prarams->filter_image| was
typo

This seems a little bit like making assumptions at some distance away, but I
can't quite see how to make that any better.

[ccameron, 2017-06-12 23:24:28]

Thanks!

https://codereview.chromium.org/2939513002/diff/60001/cc/output/gl_renderer.cc
File cc/output/gl_renderer.cc (right):

https://codereview.chromium.org/2939513002/diff/60001/cc/output/gl_renderer.c...
cc/output/gl_renderer.cc:1286: // |params->color_space| was populated when
|prarams->filter_image| was
On 2017/06/12 22:18:00, enne wrote:
> typo
> 
> This seems a little bit like making assumptions at some distance away, but I
> can't quite see how to make that any better.

Oop. Fixed.

Yeah, I felt it was worth a comment for code-archeology .. the other thought I
had was to populate |contents_resource_lock| in the |filter_image| path (way
above) but it turns out that one is a ScopedSamplerGL and the other is a
ScopedReadLockGL, so it seemed to be getting complicated

[ccameron, 2017-06-12 23:24:38]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2017-06-12 23:24:39]

The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2939513002/#ps80001
(title: "review feedback and rebaselines")

[commit-bot: I haz the power, 2017-06-12 23:25:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-13 01:56:11]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1497309878976160,
"parent_rev": "b8eb36b221b05003be9f36ffae3d2e3a5a77651e", "commit_rev":
"c196efb30c8553563fd577a15d3a0572c3d2a69e"}

[commit-bot: I haz the power, 2017-06-13 01:56:22]

Description was changed from

==========
color-profile-layer-filter.html issue

Illustration of bug and fix

BUG=730821
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
color-profile-layer-filter.html issue

Illustration of bug and fix

BUG=730821
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2939513002
Cr-Commit-Position: refs/heads/master@{#478861}
Committed:
https://chromium.googlesource.com/chromium/src/+/c196efb30c8553563fd577a15d3a...
==========

[commit-bot: I haz the power, 2017-06-13 01:56:23]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/c196efb30c8553563fd577a15d3a...