Issue 2939493004: Hide info menu item in Downloads' search mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2939493004: Hide info menu item in Downloads' search mode (Closed)

Created:
3 years, 6 months ago by Theresa

Modified:
3 years, 6 months ago

Reviewers:
huayinz, Theresa

CC:
chromium-reviews, David Trainor- moved to gerrit, agrieve+watch_chromium.org

Target Ref:
refs/branch-heads/3112

Project:
chromium

Visibility:
Public.

Hide info menu item in Downloads' search mode Before: info menu item shows when user clear edit text in search mode Now: info menu item does not show in search mode BUG=732516 TBR=twellington@chromium.org,huayinz@chromium.org Review-Url: https://codereview.chromium.org/2939523002 Cr-Original-Commit-Position: refs/heads/master@{#478764} Review-Url: https://codereview.chromium.org/2939493004 . Cr-Commit-Position: refs/branch-heads/3112@{#322} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/17836174c5a06af39ae12482c27aa8321b1fd18a

Created: 3 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerToolbar.java	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (1 generated)

Theresa

3 years, 6 months ago (2017-06-13 18:01:07 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
17836174c5a06af39ae12482c27aa8321b1fd18a.