Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2939443004: Load credentials on desktop even when there is no authenticated account ID. (Closed)

Created:
3 years, 6 months ago by msarda
Modified:
3 years, 6 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Load credentials on desktop even when there is no authenticated account ID. This CL changes the desktop token service to load the credentials for all accounts even when the SigninManager::authenticated_account_id is empty. BUG=733226 Review-Url: https://codereview.chromium.org/2939443004 Cr-Commit-Position: refs/heads/master@{#479693} Committed: https://chromium.googlesource.com/chromium/src/+/9e8c59957706918a5fbeb97ea4a338271bbc5213

Patch Set 1 #

Patch Set 2 : Unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -22 lines) Patch
M chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.cc View 1 4 chunks +20 lines, -13 lines 0 comments Download
M chrome/browser/signin/mutable_profile_oauth2_token_service_delegate_unittest.cc View 1 1 chunk +59 lines, -2 lines 0 comments Download
M components/signin/core/browser/profile_oauth2_token_service.h View 1 chunk +3 lines, -6 lines 0 comments Download
M components/signin/core/common/profile_management_switches.h View 1 chunk +4 lines, -1 line 0 comments Download
M components/signin/core/common/profile_management_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
msarda
Please take a look.
3 years, 6 months ago (2017-06-14 13:20:03 UTC) #11
Roger Tawa OOO till Jul 10th
lgtm FYI, I a wrote CL to do this several years ago which was reverted ...
3 years, 6 months ago (2017-06-14 19:23:41 UTC) #12
droger
lgtm
3 years, 6 months ago (2017-06-15 11:44:46 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939443004/20001
3 years, 6 months ago (2017-06-15 13:07:34 UTC) #15
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 14:13:58 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9e8c59957706918a5fbeb97ea4a3...

Powered by Google App Engine
This is Rietveld 408576698