Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1425)

Issue 2939433002: [ObjC ARC] Converts ios/chrome/browser/ui/sync:sync to ARC. (Closed)

Created:
3 years, 6 months ago by marq (ping after 24h)
Modified:
3 years, 6 months ago
Reviewers:
stkhapugin, msarda
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/sync:sync to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2939433002 Cr-Commit-Position: refs/heads/master@{#478993} Committed: https://chromium.googlesource.com/chromium/src/+/16b50d5d9a5c4e17fdbeee07c043186b334b08e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M ios/chrome/browser/ui/sync/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/sync/sync_error_infobar_delegate.mm View 3 chunks +6 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/sync/sync_util.mm View 2 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
marq (ping after 24h)
3 years, 6 months ago (2017-06-12 17:11:33 UTC) #6
stkhapugin
lgtm
3 years, 6 months ago (2017-06-13 12:04:08 UTC) #7
msarda
lgtm
3 years, 6 months ago (2017-06-13 13:06:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939433002/1
3 years, 6 months ago (2017-06-13 13:09:56 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 13:15:42 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/16b50d5d9a5c4e17fdbeee07c043...

Powered by Google App Engine
This is Rietveld 408576698