extensions/common/features/base_feature_provider_unittest.cc - Issue 293943002: Clean up TestFeaturesNativeHandler to use the ExtensionsClient's JSON feature sources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/features/base_feature_provider_unittest.cc

Issue 293943002: Clean up TestFeaturesNativeHandler to use the ExtensionsClient's JSON feature sources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/common/extensions_client.h ('K') | « extensions/common/extensions_client.h ('k') | extensions/common/features/feature_provider.h » ('j') | extensions/test/test_extensions_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/features/base_feature_provider_unittest.cc

diff --git a/extensions/common/features/base_feature_provider_unittest.cc b/extensions/common/features/base_feature_provider_unittest.cc

index 0d19fd47457e2fae171666e2b4373d4649aa42f2..28c8dedad51ae4436930e1482ffe9605e0c13ba2 100644

--- a/extensions/common/features/base_feature_provider_unittest.cc

+++ b/extensions/common/features/base_feature_provider_unittest.cc

@@ -27,7 +27,7 @@ SimpleFeature* CreateFeature() {

} // namespace

TEST(BaseFeatureProviderTest, ManifestFeatures) {

- FeatureProvider* provider = BaseFeatureProvider::GetByName("manifest");

+ const FeatureProvider* provider = BaseFeatureProvider::GetByName("manifest");

SimpleFeature* feature =

static_cast<SimpleFeature*>(provider->GetFeature("description"));

ASSERT_TRUE(feature);

@@ -70,7 +70,8 @@ TEST(BaseFeatureProviderTest, ManifestFeatures) {

}

TEST(BaseFeatureProviderTest, PermissionFeatures) {

- FeatureProvider* provider = BaseFeatureProvider::GetByName("permission");

+ const FeatureProvider* provider =

+ BaseFeatureProvider::GetByName("permission");

SimpleFeature* feature =

static_cast<SimpleFeature*>(provider->GetFeature("contextMenus"));

ASSERT_TRUE(feature);