Clean up TestFeaturesNativeHandler to use the ExtensionsClient's JSON feature sources.

extensions/common/features/base_feature_provider_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/common/features/base_feature_provider.h"
 
 #include "chrome/common/extensions/features/chrome_channel_feature_filter.h"
 #include "chrome/common/extensions/features/feature_channel.h"
 #include "extensions/common/features/permission_feature.h"
 #include "extensions/common/value_builder.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using chrome::VersionInfo;
 
 namespace extensions {
 
 namespace {
 
 template <class FeatureClass>
 SimpleFeature* CreateFeature() {
   SimpleFeature* feature = new FeatureClass();
   feature->AddFilter(
       scoped_ptr<SimpleFeatureFilter>(new ChromeChannelFeatureFilter(feature)));
   return feature;
 }
 
 }  // namespace
 
 TEST(BaseFeatureProviderTest, ManifestFeatures) {
-  FeatureProvider* provider = BaseFeatureProvider::GetByName("manifest");
+  const FeatureProvider* provider = BaseFeatureProvider::GetByName("manifest");
   SimpleFeature* feature =
       static_cast<SimpleFeature*>(provider->GetFeature("description"));
   ASSERT_TRUE(feature);
   EXPECT_EQ(6u, feature->extension_types()->size());
   EXPECT_EQ(1u, feature->extension_types()->count(Manifest::TYPE_EXTENSION));
   EXPECT_EQ(1u,
       feature->extension_types()->count(Manifest::TYPE_LEGACY_PACKAGED_APP));
   EXPECT_EQ(1u,
             feature->extension_types()->count(Manifest::TYPE_PLATFORM_APP));
   EXPECT_EQ(1u, feature->extension_types()->count(Manifest::TYPE_HOSTED_APP));
@@ skipping 22 matching lines @@
       extension.get(), Feature::UNSPECIFIED_CONTEXT).result());
 
   feature =
     static_cast<SimpleFeature*>(provider->GetFeature("devtools_page"));
   ASSERT_TRUE(feature);
   EXPECT_EQ(Feature::NOT_PRESENT, feature->IsAvailableToContext(
       extension.get(), Feature::UNSPECIFIED_CONTEXT).result());
 }
 
 TEST(BaseFeatureProviderTest, PermissionFeatures) {
-  FeatureProvider* provider = BaseFeatureProvider::GetByName("permission");
+  const FeatureProvider* provider =
+      BaseFeatureProvider::GetByName("permission");
   SimpleFeature* feature =
       static_cast<SimpleFeature*>(provider->GetFeature("contextMenus"));
   ASSERT_TRUE(feature);
   EXPECT_EQ(3u, feature->extension_types()->size());
   EXPECT_EQ(1u, feature->extension_types()->count(Manifest::TYPE_EXTENSION));
   EXPECT_EQ(1u,
       feature->extension_types()->count(Manifest::TYPE_LEGACY_PACKAGED_APP));
   EXPECT_EQ(1u,
             feature->extension_types()->count(Manifest::TYPE_PLATFORM_APP));
 
@@ skipping 118 matching lines @@
     EXPECT_NE(
         Feature::IS_AVAILABLE,
         feature->IsAvailableToManifest("2",
                                        Manifest::TYPE_LEGACY_PACKAGED_APP,
                                        Manifest::INVALID_LOCATION,
                                        Feature::UNSPECIFIED_PLATFORM).result());
   }
 }
 
 }  // namespace extensions