Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: extensions/common/extensions_client.h

Issue 293943002: Clean up TestFeaturesNativeHandler to use the ExtensionsClient's JSON feature sources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/extensions_client.h
diff --git a/extensions/common/extensions_client.h b/extensions/common/extensions_client.h
index 6b9c5349b01271fca1ce4323fd36ea2b9773e434..d8f58ef3b0d03d79aafc9208a41bab008a4549a4 100644
--- a/extensions/common/extensions_client.h
+++ b/extensions/common/extensions_client.h
@@ -19,6 +19,7 @@ namespace extensions {
class APIPermissionSet;
class Extension;
class FeatureProvider;
+class JSONFeatureProviderSource;
class ManifestPermissionSet;
class PermissionMessage;
class PermissionMessageProvider;
@@ -48,6 +49,12 @@ class ExtensionsClient {
virtual scoped_ptr<FeatureProvider> CreateFeatureProvider(
const std::string& name) const = 0;
+ // Create a JSONFeatureProviderSource for a specific feature type,
+ // e.g. "permission". (There are currently no other sources of features data.)
James Cook 2014/05/20 18:15:47 Doesn't this also work for "api" and "manifest"?
Yoyo Zhou 2014/05/21 01:05:47 This wording is confusing. I'll fix it.
+ // This is used primarily in CreateFeatureProvider, above.
+ virtual scoped_ptr<JSONFeatureProviderSource> CreateFeatureProviderSource(
+ const std::string& name) const = 0;
+
// Takes the list of all hosts and filters out those with special
// permission strings. Adds the regular hosts to |new_hosts|,
// and adds the special permission messages to |messages|.

Powered by Google App Engine
This is Rietveld 408576698