cc/blink: Veto checker-imaging for multipart image resources.

cc/blink: Veto checker-imaging for multipart image resources.

Multipart images resources can be used for displaying mjpg videos which
should not be checkered. Plumb this state from blink to cc using
PaintImage to veto them from checkering.

BUG=733247
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2939243002
Cr-Commit-Position: refs/heads/master@{#481216}
Committed: https://chromium.googlesource.com/chromium/src/+/54b956cfa0755b0e4777d1e422e3e560c00c6f92

[Khushal, 2017-06-16 00:25:54]

Description was changed from

==========
cc/blink: Veto checker-imaging for multipart image resources.

Multipart images resources can be used for displaying mjpg videos which
should not be checkered. Plumb this state from blink to cc using
PaintImage to veto them from checkering.

BUG=733247
==========

to

==========
cc/blink: Veto checker-imaging for multipart image resources.

Multipart images resources can be used for displaying mjpg videos which
should not be checkered. Plumb this state from blink to cc using
PaintImage to veto them from checkering.

BUG=733247
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Khushal, 2017-06-16 00:27:53]

khushalsagar@chromium.org changed reviewers:
+ chrishtr@chromium.org, vmpstr@chromium.org

[chrishtr, 2017-06-16 00:45:17]

This CL needs a test. Otherwise looks reasonable.

[vmpstr, 2017-06-16 17:35:37]

mostly nits, rs lgtm % chrishtr

https://codereview.chromium.org/2939243002/diff/1/cc/paint/paint_image.h
File cc/paint/paint_image.h (right):

https://codereview.chromium.org/2939243002/diff/1/cc/paint/paint_image.h#newc...
cc/paint/paint_image.h:78: bool is_multi_part_ = false;
nit: should this be is_multipart_?

https://codereview.chromium.org/2939243002/diff/1/cc/tiles/checker_image_trac...
File cc/tiles/checker_image_tracker.cc (right):

https://codereview.chromium.org/2939243002/diff/1/cc/tiles/checker_image_trac...
cc/tiles/checker_image_tracker.cc:187: bool can_checker_image = complete &&
static_image &&
Can you update the comment to state in words when we can checker an image (and
possibly why for cases like multipart)

https://codereview.chromium.org/2939243002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/loader/resource/ImageResource.cpp (right):

https://codereview.chromium.org/2939243002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/resource/ImageResource.cpp:345: bool
is_multi_part = !!multipart_parser_;
everything else is called multipart, so maybe this should be is_multipart :)

https://codereview.chromium.org/2939243002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/BitmapImage.cpp (right):

https://codereview.chromium.org/2939243002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/BitmapImage.cpp:83: :
Image(observer, false),
this is the default, so you can omit it

[Khushal, 2017-06-16 18:26:33]

https://codereview.chromium.org/2939243002/diff/1/cc/paint/paint_image.h
File cc/paint/paint_image.h (right):

https://codereview.chromium.org/2939243002/diff/1/cc/paint/paint_image.h#newc...
cc/paint/paint_image.h:78: bool is_multi_part_ = false;
On 2017/06/16 17:35:36, vmpstr wrote:
> nit: should this be is_multipart_?

Done.

https://codereview.chromium.org/2939243002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/loader/resource/ImageResource.cpp (right):

https://codereview.chromium.org/2939243002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/loader/resource/ImageResource.cpp:345: bool
is_multi_part = !!multipart_parser_;
On 2017/06/16 17:35:36, vmpstr wrote:
> everything else is called multipart, so maybe this should be is_multipart :)

Done.

https://codereview.chromium.org/2939243002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/BitmapImage.cpp (right):

https://codereview.chromium.org/2939243002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/BitmapImage.cpp:83: :
Image(observer, false),
On 2017/06/16 17:35:37, vmpstr wrote:
> this is the default, so you can omit it

Done.

[Khushal, 2017-06-16 18:27:53]

On 2017/06/16 00:45:17, chrishtr wrote:
> This CL needs a test. Otherwise looks reasonable.

Thanks Chris. Added a test in cc for this. I wasn't sure if there is a great
place to add a unit test in blink, and its mostly just plumbing there.

[Khushal, 2017-06-20 17:34:58]

pingy.

[chrishtr, 2017-06-20 21:22:53]

https://codereview.chromium.org/2939243002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/resource/ImageResource.cpp (right):

https://codereview.chromium.org/2939243002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/resource/ImageResource.cpp:615: bool
is_multipart = !!multipart_parser_;
Test this in ImageResourceTest.cpp?

[Khushal, 2017-06-21 02:08:44]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 02:09:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Khushal, 2017-06-21 02:13:45]

https://codereview.chromium.org/2939243002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/loader/resource/ImageResource.cpp (right):

https://codereview.chromium.org/2939243002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/loader/resource/ImageResource.cpp:615: bool
is_multipart = !!multipart_parser_;
On 2017/06/20 21:22:53, chrishtr wrote:
> Test this in ImageResourceTest.cpp?

Done.

[commit-bot: I haz the power, 2017-06-21 04:08:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 04:08:26]

Dry run: This issue passed the CQ dry run.

[chrishtr, 2017-06-21 15:13:57]

lgtm

[Khushal, 2017-06-21 15:48:16]

The CQ bit was checked by khushalsagar@chromium.org

[Khushal, 2017-06-21 15:48:16]

The patchset sent to the CQ was uploaded after l-g-t-m from vmpstr@chromium.org
Link to the patchset: https://codereview.chromium.org/2939243002/#ps40001
(title: "tested")

[commit-bot: I haz the power, 2017-06-21 15:48:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 15:54:11]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498060096474930,
"parent_rev": "863ce9d480be2fa787462ea8da9bfd9b49070047", "commit_rev":
"54b956cfa0755b0e4777d1e422e3e560c00c6f92"}

[commit-bot: I haz the power, 2017-06-21 15:54:23]

Description was changed from

==========
cc/blink: Veto checker-imaging for multipart image resources.

Multipart images resources can be used for displaying mjpg videos which
should not be checkered. Plumb this state from blink to cc using
PaintImage to veto them from checkering.

BUG=733247
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc/blink: Veto checker-imaging for multipart image resources.

Multipart images resources can be used for displaying mjpg videos which
should not be checkered. Plumb this state from blink to cc using
PaintImage to veto them from checkering.

BUG=733247
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2939243002
Cr-Commit-Position: refs/heads/master@{#481216}
Committed:
https://chromium.googlesource.com/chromium/src/+/54b956cfa0755b0e4777d1e422e3...
==========

[commit-bot: I haz the power, 2017-06-21 15:54:26]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/54b956cfa0755b0e4777d1e422e3...