Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 2939233002: CUPS: Modify the dialog title for manufacturer-and-model dialog. (Closed)

Created:
3 years, 6 months ago by xdai1
Modified:
3 years, 6 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-settings_chromium.org, srahim+watch_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

CUPS: Modify the dialog title for manufacturer-and-model dialog. BUG=721841 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2939233002 Cr-Commit-Position: refs/heads/master@{#480883} Committed: https://chromium.googlesource.com/chromium/src/+/025ab9eccbdf287a45c06cb12d401b44d3133535

Patch Set 1 #

Patch Set 2 : nit. Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/app/settings_strings.grdp View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
xdai1
michaelpg@, could you help review this CL please? Thanks!
3 years, 6 months ago (2017-06-16 00:08:41 UTC) #3
michaelpg
lgtm
3 years, 6 months ago (2017-06-19 22:40:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939233002/20001
3 years, 6 months ago (2017-06-20 16:44:54 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 18:04:36 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/025ab9eccbdf287a45c06cb12d40...

Powered by Google App Engine
This is Rietveld 408576698