Update Previews infbar accessibility string

Update Previews infbar accessibility string

The Previews infobar should read "Simplified page to save data and load
faster. Options available near bottom of the screen." when shown, rather
than reading the infobar strings.

BUG=732944
Review-Url: https://codereview.chromium.org/2939143002
Cr-Commit-Position: refs/heads/master@{#481046}
Committed: https://chromium.googlesource.com/chromium/src/+/3db9563bba1d755372c662cebb6402a4cc43e0e5

[megjablon, 2017-06-15 18:39:04]

megjablon@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[megjablon, 2017-06-15 18:39:05]

PTAL, thanks!

[gone, 2017-06-19 16:16:50]

https://codereview.chromium.org/2939143002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/PreviewsInfoBar.java
(right):

https://codereview.chromium.org/2939143002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/infobar/PreviewsInfoBar.java:38:
// TODO(googleo): Fetch the accessibility message from the compact layout.
Why is this TODO(googleo)?  Is this copied from somewhere?

[gone, 2017-06-19 16:20:45]

https://codereview.chromium.org/2939143002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/PreviewsInfoBar.java
(right):

https://codereview.chromium.org/2939143002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/infobar/PreviewsInfoBar.java:38:
// TODO(googleo): Fetch the accessibility message from the compact layout.
On 2017/06/19 16:16:50, dfalcantara wrote:
> Why is this TODO(googleo)?  Is this copied from somewhere?

Er, you should refactor it so the code's common instead of just straight copying
it from InfoBar.java.  I've already had to do janitorial work on another
function that was copied across three infobars and would like to avoid more
cleanup.

[megjablon, 2017-06-19 19:37:22]

The CQ bit was checked by megjablon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-19 19:37:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[megjablon, 2017-06-19 20:04:28]

Patchset #2 (id:20001) has been deleted

[megjablon, 2017-06-19 20:04:37]

The CQ bit was checked by megjablon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-19 20:05:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[megjablon, 2017-06-19 20:05:36]

https://codereview.chromium.org/2939143002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/infobar/PreviewsInfoBar.java
(right):

https://codereview.chromium.org/2939143002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/infobar/PreviewsInfoBar.java:38:
// TODO(googleo): Fetch the accessibility message from the compact layout.
On 2017/06/19 16:20:44, dfalcantara wrote:
> On 2017/06/19 16:16:50, dfalcantara wrote:
> > Why is this TODO(googleo)?  Is this copied from somewhere?
> 
> Er, you should refactor it so the code's common instead of just straight
copying
> it from InfoBar.java.  I've already had to do janitorial work on another
> function that was copied across three infobars and would like to avoid more
> cleanup. 

Done.

[commit-bot: I haz the power, 2017-06-19 20:55:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-19 20:55:53]

Dry run: This issue passed the CQ dry run.

[gone, 2017-06-19 21:27:05]

https://codereview.chromium.org/2939143002/diff/40001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBar.java
(right):

https://codereview.chromium.org/2939143002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBar.java:151:
return getAccessibilityMessage() +
mContext.getString(R.string.bottom_bar_screen_position);
AFAICT this isn't equivalent.

1) If mView == null and it's a compact layout, then it returns the string saying
something's at the bottom of the screen without anything actually being there.

2) If mView == null or mMessageView == null and it's not a compact layout, then
it returns the string saying something's at the bottom of the screen without
anything actually being there.

Add a test to make sure what you're doing actually matches what it did before.

[megjablon, 2017-06-20 19:53:10]

The CQ bit was checked by megjablon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 19:53:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[megjablon, 2017-06-20 20:35:54]

The CQ bit was checked by megjablon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 20:36:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[megjablon, 2017-06-20 20:36:46]

The CQ bit was checked by megjablon@chromium.org to run a CQ dry run

[megjablon, 2017-06-20 20:36:57]

Patchset #3 (id:60001) has been deleted

[commit-bot: I haz the power, 2017-06-20 20:37:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[megjablon, 2017-06-20 20:39:05]

https://codereview.chromium.org/2939143002/diff/40001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBar.java
(right):

https://codereview.chromium.org/2939143002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBar.java:151:
return getAccessibilityMessage() +
mContext.getString(R.string.bottom_bar_screen_position);
On 2017/06/19 21:27:05, dfalcantara wrote:
> AFAICT this isn't equivalent.
> 
> 1) If mView == null and it's a compact layout, then it returns the string
saying
> something's at the bottom of the screen without anything actually being there.
> 
> 2) If mView == null or mMessageView == null and it's not a compact layout,
then
> it returns the string saying something's at the bottom of the screen without
> anything actually being there.
> 
> Add a test to make sure what you're doing actually matches what it did before.

Changed it so that it's equivalent. We can have mView == null, but I couldn't
find a case where mMessageView would be null except when usesCompactLayout is
true.

[gone, 2017-06-20 20:45:23]

https://codereview.chromium.org/2939143002/diff/80001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java
(right):

https://codereview.chromium.org/2939143002/diff/80001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java:148:
@RetryOnFailure
Don't add @RetryOnFailure for new tests.  That implies you're adding a flaky
test from the get go, and you're not actually doing anything that could flake
here.

https://codereview.chromium.org/2939143002/diff/80001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java:167:
infoBarNoMessage.getAccessibilityText());
infoBarCompact.

[megjablon, 2017-06-20 20:48:00]

https://codereview.chromium.org/2939143002/diff/80001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java
(right):

https://codereview.chromium.org/2939143002/diff/80001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java:148:
@RetryOnFailure
On 2017/06/20 20:45:23, dfalcantara wrote:
> Don't add @RetryOnFailure for new tests.  That implies you're adding a flaky
> test from the get go, and you're not actually doing anything that could flake
> here.

Done.

https://codereview.chromium.org/2939143002/diff/80001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java:167:
infoBarNoMessage.getAccessibilityText());
On 2017/06/20 20:45:23, dfalcantara wrote:
> infoBarCompact.

Ugh sorry, my bad. Trying to do this while in meetings all day. Done.

[gone, 2017-06-20 20:54:50]

Good to go.

lgtm

[megjablon, 2017-06-20 21:00:29]

The CQ bit was checked by megjablon@chromium.org

[commit-bot: I haz the power, 2017-06-20 21:00:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 22:10:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 22:10:27]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[megjablon, 2017-06-20 23:35:27]

The CQ bit was checked by megjablon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 23:35:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[megjablon, 2017-06-20 23:36:06]

The CQ bit was unchecked by megjablon@chromium.org

[megjablon, 2017-06-20 23:36:07]

The CQ bit was checked by megjablon@chromium.org

[megjablon, 2017-06-20 23:36:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2939143002/#ps120001
(title: "static class")

[commit-bot: I haz the power, 2017-06-20 23:36:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 00:36:09]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1498001767312930,
"parent_rev": "941c636edf9661207927a5da8dd88a622998d1f6", "commit_rev":
"3db9563bba1d755372c662cebb6402a4cc43e0e5"}

[commit-bot: I haz the power, 2017-06-21 00:36:23]

Description was changed from

==========
Update Previews infbar accessibility string

The Previews infobar should read "Simplified page to save data and load
faster. Options available near bottom of the screen." when shown, rather
than reading the infobar strings.

BUG=732944
==========

to

==========
Update Previews infbar accessibility string

The Previews infobar should read "Simplified page to save data and load
faster. Options available near bottom of the screen." when shown, rather
than reading the infobar strings.

BUG=732944

Review-Url: https://codereview.chromium.org/2939143002
Cr-Commit-Position: refs/heads/master@{#481046}
Committed:
https://chromium.googlesource.com/chromium/src/+/3db9563bba1d755372c662cebb64...
==========

[commit-bot: I haz the power, 2017-06-21 00:36:25]

Committed patchset #5 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/3db9563bba1d755372c662cebb64...