Added to options page to let users change keyboard mappings.

Added to options page to let users change keyboard mappings.

BUG=593885
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2939133004
Cr-Commit-Position: refs/heads/master@{#481272}
Committed: https://chromium.googlesource.com/chromium/src/+/267d44699d370e8141f21e856055e58bebaeb1a7

[elichtenberg, 2017-06-15 21:21:17]

Description was changed from

==========
Added to options page to let users change keyboard mappings.

BUG=593885
==========

to

==========
Added to options page to let users change keyboard mappings.

BUG=593885
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[elichtenberg, 2017-06-15 21:21:26]

The CQ bit was checked by elichtenberg@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-15 21:22:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[elichtenberg, 2017-06-15 21:26:04]

elichtenberg@google.com changed reviewers:
+ dmazzoni@chromium.org, dtseng@chromium.org

[commit-bot: I haz the power, 2017-06-15 21:32:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 21:32:07]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[elichtenberg, 2017-06-15 21:49:18]

The CQ bit was checked by elichtenberg@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-15 21:50:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmazzoni, 2017-06-15 22:37:40]

https://codereview.chromium.org/2939133004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/switch_access/keyboard_handler.js
(right):

https://codereview.chromium.org/2939133004/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/switch_access/keyboard_handler.js:71: switch
(event.keyCode) {
One possibility here would be a map from command name (like 'next') to
a command like this.switchAccess_.moveToNode(true). Something like:

commandMap['next'] = this.switchAccess_.moveToNode.bind(this, true);
...

Then you could iterate over the commands and if one of them
matches keyCode, call it (and log the command name).

https://codereview.chromium.org/2939133004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/switch_access/options.html (right):

https://codereview.chromium.org/2939133004/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/switch_access/options.html:44: <label>
How about hiding these? Maybe we could make a secret url that makes these
visible but not show them by default.

As Switch Access is getting more polished I think it'd be good to turn off
the debug key bindings by default but still allow them for people who want them.

[commit-bot: I haz the power, 2017-06-15 23:30:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 23:30:07]

Dry run: This issue passed the CQ dry run.

[elichtenberg, 2017-06-19 23:24:29]

The CQ bit was checked by elichtenberg@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-19 23:24:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-19 23:34:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-19 23:34:25]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[elichtenberg, 2017-06-20 01:00:17]

The CQ bit was checked by elichtenberg@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 01:00:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[elichtenberg, 2017-06-20 01:02:30]

https://codereview.chromium.org/2939133004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/switch_access/keyboard_handler.js
(right):

https://codereview.chromium.org/2939133004/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/switch_access/keyboard_handler.js:71: switch
(event.keyCode) {
On 2017/06/15 22:37:39, dmazzoni wrote:
> One possibility here would be a map from command name (like 'next') to
> a command like this.switchAccess_.moveToNode(true). Something like:
> 
> commandMap['next'] = this.switchAccess_.moveToNode.bind(this, true);
> ...
> 
> Then you could iterate over the commands and if one of them
> matches keyCode, call it (and log the command name).

Done. Put command map in commands.js

https://codereview.chromium.org/2939133004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/switch_access/options.html (right):

https://codereview.chromium.org/2939133004/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/switch_access/options.html:44: <label>
On 2017/06/15 22:37:39, dmazzoni wrote:
> How about hiding these? Maybe we could make a secret url that makes these
> visible but not show them by default.
> 
> As Switch Access is getting more polished I think it'd be good to turn off
> the debug key bindings by default but still allow them for people who want
them.
> 

Set display to none for debug options, and removed default key bindings

[commit-bot: I haz the power, 2017-06-20 03:03:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 03:03:13]

Dry run: This issue passed the CQ dry run.

[dmazzoni, 2017-06-21 06:11:41]

lgtm

[elichtenberg, 2017-06-21 16:28:30]

The CQ bit was checked by elichtenberg@google.com

[commit-bot: I haz the power, 2017-06-21 16:28:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 16:30:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 16:30:45]

Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[elichtenberg, 2017-06-21 16:37:45]

The CQ bit was checked by elichtenberg@google.com

[commit-bot: I haz the power, 2017-06-21 16:37:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 16:40:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 16:40:33]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[elichtenberg, 2017-06-21 17:41:29]

The CQ bit was checked by elichtenberg@google.com

[elichtenberg, 2017-06-21 17:41:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2939133004/#ps80001
(title: "Fixed merge conflict and formatting error")

[commit-bot: I haz the power, 2017-06-21 17:41:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 19:15:48]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1498066889084910,
"parent_rev": "2c1625fbce058a4f78a26e782c8a7881d65f758e", "commit_rev":
"7eb154f9d72d1cbfdceb4cc32ded38d3df12b0fe"}

[commit-bot: I haz the power, 2017-06-21 19:16:08]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1498066889084910,
"parent_rev": "7718ac3cc5e6b0d1aabcecf1312455ceacf7ef64", "commit_rev":
"267d44699d370e8141f21e856055e58bebaeb1a7"}

[commit-bot: I haz the power, 2017-06-21 19:16:22]

Description was changed from

==========
Added to options page to let users change keyboard mappings.

BUG=593885
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Added to options page to let users change keyboard mappings.

BUG=593885
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2939133004
Cr-Commit-Position: refs/heads/master@{#481272}
Committed:
https://chromium.googlesource.com/chromium/src/+/267d44699d370e8141f21e856055...
==========

[commit-bot: I haz the power, 2017-06-21 19:16:23]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/267d44699d370e8141f21e856055...