Strong mode cleaning of many dart2js tests.

Strong mode cleaning of many dart2js tests.

R=efortuna@google.com

Committed: https://github.com/dart-lang/sdk/commit/2e6e44a69b0f072b39a1984683475a965a1f903f

[ahe, 2017-06-15 13:51:54]

ahe@google.com changed reviewers:
+ efortuna@google.com, johnniwinther@google.com

[Emily Fortuna, 2017-06-15 18:33:10]

lgtm

https://codereview.chromium.org/2939063002/diff/1/tests/compiler/dart2js/anal...
File tests/compiler/dart2js/analyze_helper.dart (right):

https://codereview.chromium.org/2939063002/diff/1/tests/compiler/dart2js/anal...
tests/compiler/dart2js/analyze_helper.dart:42: Map<String, Map<dynamic /*
String|MessageKind */, int>> whiteListMap =
who knew strong mode had whitespacing preferences?! 
I'm kidding. This makes it more readable. :-)

https://codereview.chromium.org/2939063002/diff/1/tests/compiler/dart2js/call...
File tests/compiler/dart2js/call_site_simple_type_inferer_test.dart (right):

https://codereview.chromium.org/2939063002/diff/1/tests/compiler/dart2js/call...
tests/compiler/dart2js/call_site_simple_type_inferer_test.dart:17: dynamic cls =
findElement(compiler, className);
ClassElement?

https://codereview.chromium.org/2939063002/diff/1/tests/compiler/dart2js/worl...
File tests/compiler/dart2js/world_test.dart (right):

https://codereview.chromium.org/2939063002/diff/1/tests/compiler/dart2js/worl...
tests/compiler/dart2js/world_test.dart:246: ClassElement cls =
env.getElement(name);
Johnni's not going to like this change -- he's trying to move to Entities rather
than Elements.... perhaps better to call it dynamic? :-P

[ahe, 2017-06-16 07:26:46]

Thank you, Emily!

https://codereview.chromium.org/2939063002/diff/1/tests/compiler/dart2js/anal...
File tests/compiler/dart2js/analyze_helper.dart (right):

https://codereview.chromium.org/2939063002/diff/1/tests/compiler/dart2js/anal...
tests/compiler/dart2js/analyze_helper.dart:42: Map<String, Map<dynamic /*
String|MessageKind */, int>> whiteListMap =
On 2017/06/15 18:33:10, Emily Fortuna wrote:
> who knew strong mode had whitespacing preferences?! 
> I'm kidding. This makes it more readable. :-)

These whitespace changes are important :-O

See https://github.com/dart-lang/sdk/issues/29888

https://codereview.chromium.org/2939063002/diff/1/tests/compiler/dart2js/call...
File tests/compiler/dart2js/call_site_simple_type_inferer_test.dart (right):

https://codereview.chromium.org/2939063002/diff/1/tests/compiler/dart2js/call...
tests/compiler/dart2js/call_site_simple_type_inferer_test.dart:17: dynamic cls =
findElement(compiler, className);
On 2017/06/15 18:33:10, Emily Fortuna wrote:
> ClassElement?

Done.

https://codereview.chromium.org/2939063002/diff/1/tests/compiler/dart2js/worl...
File tests/compiler/dart2js/world_test.dart (right):

https://codereview.chromium.org/2939063002/diff/1/tests/compiler/dart2js/worl...
tests/compiler/dart2js/world_test.dart:246: ClassElement cls =
env.getElement(name);
On 2017/06/15 18:33:10, Emily Fortuna wrote:
> Johnni's not going to like this change -- he's trying to move to Entities
rather
> than Elements.... perhaps better to call it dynamic? :-P

Hopefully, this will assist Johnni in finding places that need more work to move
to entities.

[ahe, 2017-06-16 07:31:35]

Description was changed from

==========
Strong mode cleaning of many dart2js tests.
==========

to

==========
Strong mode cleaning of many dart2js tests.

R=efortuna@google.com

Committed:
https://github.com/dart-lang/sdk/commit/2e6e44a69b0f072b39a1984683475a965a1f903f
==========

[ahe, 2017-06-16 07:31:36]

Committed patchset #2 (id:20001) manually as
2e6e44a69b0f072b39a1984683475a965a1f903f (presubmit successful).

[Johnni Winther, 2017-06-16 08:00:12]

https://codereview.chromium.org/2939063002/diff/1/tests/compiler/dart2js/worl...
File tests/compiler/dart2js/world_test.dart (right):

https://codereview.chromium.org/2939063002/diff/1/tests/compiler/dart2js/worl...
tests/compiler/dart2js/world_test.dart:246: ClassElement cls =
env.getElement(name);
On 2017/06/16 07:26:46, ahe wrote:
> On 2017/06/15 18:33:10, Emily Fortuna wrote:
> > Johnni's not going to like this change -- he's trying to move to Entities
> rather
> > than Elements.... perhaps better to call it dynamic? :-P
> 
> Hopefully, this will assist Johnni in finding places that need more work to
move
> to entities.

Acknowledged.

[Johnni Winther, 2017-06-16 08:36:00]

https://codereview.chromium.org/2939063002/diff/20001/tests/compiler/dart2js/...
File tests/compiler/dart2js/inference/data/super_set.dart (right):

https://codereview.chromium.org/2939063002/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/inference/data/super_set.dart:15: return a.
/*[exact=Sub]*/ method;
The added space breaks the inference tests.

[ahe, 2017-06-16 08:50:23]

https://codereview.chromium.org/2939063002/diff/20001/tests/compiler/dart2js/...
File tests/compiler/dart2js/inference/data/super_set.dart (right):

https://codereview.chromium.org/2939063002/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/inference/data/super_set.dart:15: return a.
/*[exact=Sub]*/ method;
On 2017/06/16 08:36:00, Johnni Winther wrote:
> The added space breaks the inference tests.

OK. That's on dartfmt. I'll discuss this in person with you.