tests/compiler/dart2js/simple_inferrer_global_field_closure_test.dart - Issue 2939063002: Strong mode cleaning of many dart2js tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/simple_inferrer_global_field_closure_test.dart

Issue 2939063002: Strong mode cleaning of many dart2js tests. (Closed)

Patch Set: Use ClassElement. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tests/compiler/dart2js/inference/data/super_set.dart ('K') | « tests/compiler/dart2js/simple_inferrer_global_field_closure2_test.dart ('k') | tests/compiler/dart2js/simple_inferrer_postfix_prefix_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/compiler/dart2js/simple_inferrer_global_field_closure_test.dart

diff --git a/tests/compiler/dart2js/simple_inferrer_global_field_closure_test.dart b/tests/compiler/dart2js/simple_inferrer_global_field_closure_test.dart

index 430f46422151c444d8236dfddc8d0a4065693187..80674f18e6ef26f8237a19b4f0857d154a861a36 100644

--- a/tests/compiler/dart2js/simple_inferrer_global_field_closure_test.dart

+++ b/tests/compiler/dart2js/simple_inferrer_global_field_closure_test.dart

@@ -42,10 +42,8 @@ void main() {

checkReturn(String name, type) {

var element = findElement(compiler, name);

- Expect.equals(

- type,

- typesInferrer.getReturnTypeOfElement(element).simplify(compiler),

- name);

+ dynamic returnType = typesInferrer.getReturnTypeOfElement(element);

+ Expect.equals(type, returnType.simplify(compiler), name);

}

checkReturn('method1', closedWorld.commonMasks.uint31Type);