Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2939043004: Remove duplicate NodeList#forEach definition now that Closure itself has this (Closed)

Created:
3 years, 6 months ago by Dan Beam
Modified:
3 years, 6 months ago
Reviewers:
dmazzoni, dpapad
CC:
dpapad, aboxhall+watch_chromium.org, alemate+watch_chromium.org, aleventhal+watch_chromium.org, arv+watch_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dougt+watch_chromium.org, dtseng+watch_chromium.org, je_julie, nektar+watch_chromium.org, oshima+watch_chromium.org, yuzo+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove duplicate NodeList#forEach definition now that Closure itself has this This fixes the presubmit, which was broken by a recent Closure copmiler roll. TBR=dmazzoni@chromium.org BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2939043004 Cr-Commit-Position: refs/heads/master@{#480227} Committed: https://chromium.googlesource.com/chromium/src/+/e7b81e06f00fc7bb02bd722ac5a93295da11302d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/externs.js View 1 chunk +0 lines, -9 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (11 generated)
Dan Beam
3 years, 6 months ago (2017-06-16 22:09:14 UTC) #4
dpapad
LGTM. The NodeList#forEach externs have been added in Closure Compiler itself.
3 years, 6 months ago (2017-06-16 22:12:10 UTC) #8
Dan Beam
TBR=dmazzoni@ because i don't think there's much other to do than this
3 years, 6 months ago (2017-06-16 22:13:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939043004/1
3 years, 6 months ago (2017-06-16 22:14:21 UTC) #13
dmazzoni
lgtm Thanks!
3 years, 6 months ago (2017-06-16 23:05:34 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 23:49:52 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e7b81e06f00fc7bb02bd722ac5a9...

Powered by Google App Engine
This is Rietveld 408576698