Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2939033002: Towards compiling Hello World! (Closed)

Created:
3 years, 6 months ago by Johnni Winther
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated cf. comments #

Patch Set 3 : Rebased #

Patch Set 4 : Fix parameter ordering #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -99 lines) Patch
M pkg/compiler/lib/src/common/codegen.dart View 3 chunks +6 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 2 2 chunks +9 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/constants/expressions.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/elements/entities.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/elements/types.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_emitter.dart View 6 chunks +9 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart View 3 chunks +7 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/element_strategy.dart View 1 2 2 chunks +7 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 1 2 4 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/native_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart View 1 2 9 chunks +14 lines, -24 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/collector.dart View 1 2 chunks +5 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 1 2 5 chunks +10 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_model/js_strategy.dart View 1 2 1 chunk +7 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map.dart View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 1 2 3 3 chunks +36 lines, -0 lines 3 comments Download
M pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart View 1 2 2 chunks +9 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/serialization/system.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/ssa/types.dart View 2 chunks +6 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/codegen_world_builder.dart View 1 2 3 7 chunks +35 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/universe/world_builder.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/type_representation_test.dart View 1 2 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 16 (4 generated)
Johnni Winther
3 years, 6 months ago (2017-06-15 11:07:40 UTC) #2
Emily Fortuna
lgtm https://giphy.com/gifs/bravo-EPqffuXDoQXq8
3 years, 6 months ago (2017-06-15 17:46:34 UTC) #3
Siggi Cherem (dart-lang)
lgtm! https://codereview.chromium.org/2939033002/diff/1/pkg/compiler/lib/src/elements/entities.dart File pkg/compiler/lib/src/elements/entities.dart (right): https://codereview.chromium.org/2939033002/diff/1/pkg/compiler/lib/src/elements/entities.dart#newcode256 pkg/compiler/lib/src/elements/entities.dart:256: int get parameters => positionalParameters + namedParameters.length; nit: ...
3 years, 6 months ago (2017-06-15 17:55:17 UTC) #4
Johnni Winther
https://codereview.chromium.org/2939033002/diff/1/pkg/compiler/lib/src/elements/entities.dart File pkg/compiler/lib/src/elements/entities.dart (right): https://codereview.chromium.org/2939033002/diff/1/pkg/compiler/lib/src/elements/entities.dart#newcode256 pkg/compiler/lib/src/elements/entities.dart:256: int get parameters => positionalParameters + namedParameters.length; On 2017/06/15 ...
3 years, 6 months ago (2017-06-16 08:14:23 UTC) #5
Johnni Winther
Committed patchset #2 (id:20001) manually as 778feb0504759885271e166d76f0924c3bdfdb08 (presubmit successful).
3 years, 6 months ago (2017-06-16 08:49:22 UTC) #7
Johnni Winther
PTAL @ the last patch
3 years, 6 months ago (2017-06-16 12:40:27 UTC) #9
Johnni Winther
Committed patchset #4 (id:60001) manually as 208744eab720ea257309c46ff1141ea319a9caf9 (presubmit successful).
3 years, 6 months ago (2017-06-16 12:48:33 UTC) #11
Johnni Winther
https://codereview.chromium.org/2939033002/diff/60001/pkg/compiler/lib/src/kernel/element_map_impl.dart File pkg/compiler/lib/src/kernel/element_map_impl.dart (right): https://codereview.chromium.org/2939033002/diff/60001/pkg/compiler/lib/src/kernel/element_map_impl.dart#newcode1104 pkg/compiler/lib/src/kernel/element_map_impl.dart:1104: ..sort(namedOrdering).forEach(handleParameter); .forEach changed to ..forEach before commit
3 years, 6 months ago (2017-06-16 12:57:17 UTC) #12
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2939033002/diff/60001/pkg/compiler/lib/src/kernel/element_map_impl.dart File pkg/compiler/lib/src/kernel/element_map_impl.dart (right): https://codereview.chromium.org/2939033002/diff/60001/pkg/compiler/lib/src/kernel/element_map_impl.dart#newcode1103 pkg/compiler/lib/src/kernel/element_map_impl.dart:1103: functionNode.namedParameters.toList() alternatively - we could mutate the original ...
3 years, 6 months ago (2017-06-16 16:31:10 UTC) #13
Emily Fortuna
lgtm
3 years, 6 months ago (2017-06-16 17:37:07 UTC) #14
Johnni Winther
https://codereview.chromium.org/2939033002/diff/60001/pkg/compiler/lib/src/kernel/element_map_impl.dart File pkg/compiler/lib/src/kernel/element_map_impl.dart (right): https://codereview.chromium.org/2939033002/diff/60001/pkg/compiler/lib/src/kernel/element_map_impl.dart#newcode1103 pkg/compiler/lib/src/kernel/element_map_impl.dart:1103: functionNode.namedParameters.toList() On 2017/06/16 16:31:09, Siggi Cherem (dart-lang) wrote: > ...
3 years, 6 months ago (2017-06-19 12:45:42 UTC) #15
Siggi Cherem (dart-lang)
3 years, 6 months ago (2017-06-19 16:19:20 UTC) #16
Message was sent while issue was closed. 
On 2017/06/19 12:45:42, Johnni Winther wrote:
>
https://codereview.chromium.org/2939033002/diff/60001/pkg/compiler/lib/src/ke...
> File pkg/compiler/lib/src/kernel/element_map_impl.dart (right):
> 
>
https://codereview.chromium.org/2939033002/diff/60001/pkg/compiler/lib/src/ke...
> pkg/compiler/lib/src/kernel/element_map_impl.dart:1103:
> functionNode.namedParameters.toList()
> On 2017/06/16 16:31:09, Siggi Cherem (dart-lang) wrote:
> > alternatively - we could mutate the original once, sort it and keep it
sorted
> > throughout (e.g. sort the first time we discover a function in the enqueuer,
> for
> > instance)
> 
> I don't like mutating our input (and relying upon the data flow) - and Peter
> plans to sort them in .dill, anyway.

Correct, the reason I suggest it is because it would resemble how the input will
look like once it's fixed in fasta.

Powered by Google App Engine
This is Rietveld 408576698