Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Unified Diff: pkg/compiler/lib/src/compiler.dart

Issue 2939033002: Towards compiling Hello World! (Closed)
Patch Set: Fix parameter ordering Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/compiler.dart
diff --git a/pkg/compiler/lib/src/compiler.dart b/pkg/compiler/lib/src/compiler.dart
index 27bab26f7a08ee07145463f696c3e10bc36ae3e4..131462d4c35400214989ac881ad92e28f01a915c 100644
--- a/pkg/compiler/lib/src/compiler.dart
+++ b/pkg/compiler/lib/src/compiler.dart
@@ -613,10 +613,7 @@ abstract class Compiler {
reporter.log('Compiling...');
phase = PHASE_COMPILING;
- Enqueuer codegenEnqueuer = enqueuer.createCodegenEnqueuer(closedWorld);
- _codegenWorldBuilder = codegenEnqueuer.worldBuilder;
- codegenEnqueuer.applyImpact(
- backend.onCodegenStart(closedWorld, _codegenWorldBuilder));
+ Enqueuer codegenEnqueuer = startCodegen(closedWorld);
if (compileAll) {
libraryLoader.libraries.forEach((LibraryEntity library) {
codegenEnqueuer.applyImpact(computeImpactForLibrary(library));
@@ -639,6 +636,14 @@ abstract class Compiler {
checkQueues(resolutionEnqueuer, codegenEnqueuer);
});
+ Enqueuer startCodegen(ClosedWorld closedWorld) {
+ Enqueuer codegenEnqueuer = enqueuer.createCodegenEnqueuer(closedWorld);
+ _codegenWorldBuilder = codegenEnqueuer.worldBuilder;
+ codegenEnqueuer
+ .applyImpact(backend.onCodegenStart(closedWorld, _codegenWorldBuilder));
+ return codegenEnqueuer;
+ }
+
/// Perform the steps needed to fully end the resolution phase.
ClosedWorldRefiner closeResolution(FunctionEntity mainFunction) {
phase = PHASE_DONE_RESOLVING;

Powered by Google App Engine
This is Rietveld 408576698