Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2939023003: Reduce indentation in TraverseInternalAlgorithm() for {Left,Right}PositionOf() (Closed)

Created:
3 years, 6 months ago by yosin_UTC9
Modified:
3 years, 6 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce indentation in TraverseInternalAlgorithm() for {Left,Right}PositionOf() This patch changes |TraverseInternalAlgorithm()| in |{Left,Right}PositionOf()| to use early-break style, e.g. move break-statement at end of if-else-statement to inside then-clause, to reduce indentation for improving readability. BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2939023003 Cr-Commit-Position: refs/heads/master@{#480338} Committed: https://chromium.googlesource.com/chromium/src/+/2a3854354e0d85a1ba68d3468795a261c4a72052

Patch Set 1 : 2017-06-16T18:40:17 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M third_party/WebKit/Source/core/editing/SelectionModifierCharacter.cpp View 1 chunk +15 lines, -15 lines 0 comments Download

Messages

Total messages: 23 (17 generated)
yosin_UTC9
PTAL
3 years, 6 months ago (2017-06-16 09:41:22 UTC) #11
Xiaocheng
lgtm
3 years, 6 months ago (2017-06-16 18:13:03 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939023003/20001
3 years, 6 months ago (2017-06-17 03:02:47 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/470304)
3 years, 6 months ago (2017-06-17 03:06:00 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2939023003/20001
3 years, 6 months ago (2017-06-19 01:58:42 UTC) #20
commit-bot: I haz the power
3 years, 6 months ago (2017-06-19 03:42:07 UTC) #23
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2a3854354e0d85a1ba68d3468795...

Powered by Google App Engine
This is Rietveld 408576698