|
|
Created:
3 years, 6 months ago by yosin_UTC9 Modified:
3 years, 6 months ago CC:
blink-reviews, chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionReduce indentation in TraverseInternalAlgorithm() for {Left,Right}PositionOf()
This patch changes |TraverseInternalAlgorithm()| in |{Left,Right}PositionOf()|
to use early-break style, e.g. move break-statement at end of if-else-statement
to inside then-clause, to reduce indentation for improving readability.
BUG=707656
TEST=n/a; no behavior changes
Review-Url: https://codereview.chromium.org/2939023003
Cr-Commit-Position: refs/heads/master@{#480338}
Committed: https://chromium.googlesource.com/chromium/src/+/2a3854354e0d85a1ba68d3468795a261c4a72052
Patch Set 1 : 2017-06-16T18:40:17 #
Messages
Total messages: 23 (17 generated)
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== 2017-06-16T18:24:34 BUG=70765 2017-06-16T18:24:13 ========== to ========== Reduce indentation in TraverseInternalAlgorithm() for {Left,Right}PositionOf() This patch changes |TraverseInternalAlgorithm()| in |{Left,Right}PositionOf()| to use early-break style to reduce indentation for improving readability. BUG=707656 TEST=n/a; no behavior changes ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
Description was changed from ========== Reduce indentation in TraverseInternalAlgorithm() for {Left,Right}PositionOf() This patch changes |TraverseInternalAlgorithm()| in |{Left,Right}PositionOf()| to use early-break style to reduce indentation for improving readability. BUG=707656 TEST=n/a; no behavior changes ========== to ========== Reduce indentation in TraverseInternalAlgorithm() for {Left,Right}PositionOf() This patch changes |TraverseInternalAlgorithm()| in |{Left,Right}PositionOf()| to use early-break style, e.g. move break-statement at end of if-else-statement to inside then-clause, to reduce indentation for improving readability. BUG=707656 TEST=n/a; no behavior changes ==========
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Patchset #1 (id:1) has been deleted
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
yosin@chromium.org changed reviewers: + xiaochengh@chromium.org, yoichio@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
lgtm
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by yosin@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497837506576110, "parent_rev": "38c57515aad29dfce4bd77c885ba937c5b93371b", "commit_rev": "2a3854354e0d85a1ba68d3468795a261c4a72052"}
Message was sent while issue was closed.
Description was changed from ========== Reduce indentation in TraverseInternalAlgorithm() for {Left,Right}PositionOf() This patch changes |TraverseInternalAlgorithm()| in |{Left,Right}PositionOf()| to use early-break style, e.g. move break-statement at end of if-else-statement to inside then-clause, to reduce indentation for improving readability. BUG=707656 TEST=n/a; no behavior changes ========== to ========== Reduce indentation in TraverseInternalAlgorithm() for {Left,Right}PositionOf() This patch changes |TraverseInternalAlgorithm()| in |{Left,Right}PositionOf()| to use early-break style, e.g. move break-statement at end of if-else-statement to inside then-clause, to reduce indentation for improving readability. BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2939023003 Cr-Commit-Position: refs/heads/master@{#480338} Committed: https://chromium.googlesource.com/chromium/src/+/2a3854354e0d85a1ba68d3468795... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/src/+/2a3854354e0d85a1ba68d3468795... |