Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2938963002:
Suppress layout tests for upcoming Skia roll (Closed)
|
Created:
3 years, 6 months ago by robertphillips Modified:
3 years, 6 months ago CC:
chromium-reviews, blink-reviews, rmistry Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionSuppress layout tests for upcoming Skia roll
TBR=fmalita@chromium.org
BUG=733428
Review-Url: https://codereview.chromium.org/2938963002
Cr-Commit-Position: refs/heads/master@{#479561}
Committed: https://chromium.googlesource.com/chromium/src/+/028b16ea23c0a9df02944a649ea434136fe681be
Patch Set 1 #
Messages
Total messages: 20 (14 generated)
Description was changed from ========== Suppress layout tests for upcoming Skia roll BUG=733428 ========== to ========== Suppress layout tests for upcoming Skia roll TBR=fmalita@chromium.org BUG=733428 ==========
robertphillips@google.com changed reviewers: + fmalita@chromium.org, reed@google.com
The CQ bit was checked by robertphillips@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by robertphillips@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
robertphillips@chromium.org changed reviewers: + robertphillips@chromium.org
lgtm
The CQ bit was checked by robertphillips@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1497487400884340, "parent_rev":
"4e04f5808e38a8d8bba678ea29abe8aa059871a6", "commit_rev":
"68442298e5fd4aba36a1d17d449aca820c3c360a"}
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1497487400884340, "parent_rev":
"b8a637aba5d330a6d002302e376e4952d5ca4482", "commit_rev":
"028b16ea23c0a9df02944a649ea434136fe681be"}
Message was sent while issue was closed.
Description was changed from ========== Suppress layout tests for upcoming Skia roll TBR=fmalita@chromium.org BUG=733428 ========== to ========== Suppress layout tests for upcoming Skia roll TBR=fmalita@chromium.org BUG=733428 Review-Url: https://codereview.chromium.org/2938963002 Cr-Commit-Position: refs/heads/master@{#479561} Committed: https://chromium.googlesource.com/chromium/src/+/028b16ea23c0a9df02944a649ea4... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/028b16ea23c0a9df02944a649ea4...
Message was sent while issue was closed.
Patchset #2 (id:20001) has been deleted |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
