Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2938953003: Remove redundant IsFullscreenAppListEnabled() (Closed)

Created:
3 years, 6 months ago by weidongg
Modified:
3 years, 6 months ago
Reviewers:
xiyuan, newcomer
CC:
chromium-reviews, tfarina, Matt Giuca
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove redundant IsFullscreenAppListEnabled() Call featuers::IsFullscreenAppListEnabled() once and cache it. This is a follow up CL for issue 2938563002. BUG=732067 TEST="Add --enable-features=EnableFullscreenAppList to see the changes" Review-Url: https://codereview.chromium.org/2938953003 Cr-Commit-Position: refs/heads/master@{#479829} Committed: https://chromium.googlesource.com/chromium/src/+/4b7bd924b5d4c938a1df51270fa7bd74e632f66a

Patch Set 1 #

Total comments: 2

Patch Set 2 : bool->const bool #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M ui/app_list/views/apps_grid_view.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ui/app_list/views/apps_grid_view.cc View 4 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
weidongg
This is a follow up CL to https://codereview.chromium.org/2938563002/, as that CL has been checked in ...
3 years, 6 months ago (2017-06-15 19:38:53 UTC) #2
xiyuan
lgtm https://codereview.chromium.org/2938953003/diff/1/ui/app_list/views/apps_grid_view.h File ui/app_list/views/apps_grid_view.h (right): https://codereview.chromium.org/2938953003/diff/1/ui/app_list/views/apps_grid_view.h#newcode550 ui/app_list/views/apps_grid_view.h:550: bool is_fullscreen_app_list_enabled_; nit: const bool since we don't ...
3 years, 6 months ago (2017-06-15 19:40:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2938953003/1
3 years, 6 months ago (2017-06-15 19:40:52 UTC) #5
newcomer
lgtm lgtm
3 years, 6 months ago (2017-06-15 19:47:21 UTC) #6
newcomer
lgtm lgtm lgtm
3 years, 6 months ago (2017-06-15 19:47:24 UTC) #7
newcomer
lgtm
3 years, 6 months ago (2017-06-15 19:47:27 UTC) #8
newcomer
lgtm
3 years, 6 months ago (2017-06-15 19:47:27 UTC) #9
weidongg
Thanks for the review. https://codereview.chromium.org/2938953003/diff/1/ui/app_list/views/apps_grid_view.h File ui/app_list/views/apps_grid_view.h (right): https://codereview.chromium.org/2938953003/diff/1/ui/app_list/views/apps_grid_view.h#newcode550 ui/app_list/views/apps_grid_view.h:550: bool is_fullscreen_app_list_enabled_; On 2017/06/15 19:40:05, ...
3 years, 6 months ago (2017-06-15 20:30:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2938953003/20001
3 years, 6 months ago (2017-06-15 20:31:32 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 21:09:55 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4b7bd924b5d4c938a1df51270fa7...

Powered by Google App Engine
This is Rietveld 408576698