Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2938923004: Get rid of redundant block scope from ComputeInlineBoxPositionForTextNode() (Closed)

Created:
3 years, 6 months ago by yosin_UTC9
Modified:
3 years, 6 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of redundant block scope from ComputeInlineBoxPositionForTextNode() This patch gets rid of redundant block scope from |ComputeInlineBoxPositionForTextNode()| for improving code health. BUG=707656 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2938923004 Cr-Commit-Position: refs/heads/master@{#479899} Committed: https://chromium.googlesource.com/chromium/src/+/e7b173d3f09519dccd5cd6fbc1d55bd300a895ae

Patch Set 1 : 2017-06-15T18:24:45 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -27 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 1 chunk +23 lines, -27 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
yosin_UTC9
PTAL
3 years, 6 months ago (2017-06-15 09:44:13 UTC) #8
Xiaocheng
lgtm
3 years, 6 months ago (2017-06-15 18:06:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2938923004/20001
3 years, 6 months ago (2017-06-15 23:29:36 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-06-16 01:50:12 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e7b173d3f09519dccd5cd6fbc1d5...

Powered by Google App Engine
This is Rietveld 408576698