Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2938883002: Reland reverted patch once the webkit tests that were failing are (Closed)

Created:
3 years, 6 months ago by Miguel Garcia
Modified:
3 years, 6 months ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, Peter Beverloo, chromium-apps-reviews_chromium.org, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland reverted patch once the webkit tests that were failing are fixed (by reverting an unintended change). Revert "Revert of Deprecate native and extension notification delegates. (patchset #2 id:20001 of https://codereview.chromium.org/2928303002/ )" This reverts commit b960aca0d0a3938b7400d508128eadf3951fc00d. TBR=peter@chromium.org BUG=720345 Review-Url: https://codereview.chromium.org/2938883002 Cr-Commit-Position: refs/heads/master@{#479445} Committed: https://chromium.googlesource.com/chromium/src/+/30dfc2e872643debcbd686c4ef47832adc2ac7be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -291 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/notifications/extension_notification_handler.h View 3 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/notifications/extension_notification_handler.cc View 2 chunks +43 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/notifications/notifications_api.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/notifications/notifications_api.cc View 5 chunks +4 lines, -175 lines 0 comments Download
M chrome/browser/extensions/api/notifications/notifications_apitest.cc View 1 chunk +1 line, -0 lines 0 comments Download
D chrome/browser/notifications/native_notification_delegate.h View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/notifications/native_notification_delegate.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/notifications/non_persistent_notification_handler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/notifications/non_persistent_notification_handler.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/notifications/notification_common.h View 2 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/notifications/notification_common.cc View 2 chunks +60 lines, -0 lines 0 comments Download
M chrome/browser/notifications/notification_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/notification_display_service.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/notifications/notification_display_service.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/notifications/notification_handler.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/notifications/persistent_notification_handler.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/notifications/persistent_notification_handler.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/notifications/platform_notification_service_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/platform_notification_service_interactive_uitest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/notifications/platform_notification_service_unittest.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/notifications/stub_notification_display_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/notifications/stub_notification_display_service.cc View 3 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/notifications/web_notification_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/notifications/web_notification_delegate.cc View 2 chunks +6 lines, -58 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
Miguel Garcia
Landing TBR since this is just undoing a revert. The only small change needed was ...
3 years, 6 months ago (2017-06-14 16:29:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2938883002/1
3 years, 6 months ago (2017-06-14 16:30:53 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-14 18:18:23 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/30dfc2e872643debcbd686c4ef47...

Powered by Google App Engine
This is Rietveld 408576698