Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2938863002: Merge "cros: Fix loading user profile w/o UserSessionManager" (Closed)

Created:
3 years, 6 months ago by xiyuan
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Merge "cros: Fix loading user profile w/o UserSessionManager" > The fallback logic in GetActiveUserOrOffTheRecordProfileFromPath > should cover the case when the user profile loading has not started. > So that it does not creates/loads user profile accidentally without > going through UserSessionManager. > > BUG=728683, 718734 > TEST=ProfileManagerTest.UserProfileLoading > > Review-Url: https://codereview.chromium.org/2918203002 > Cr-Commit-Position: refs/heads/master@{#478735} > (cherry picked from commit 41d32a3c1bd0153aa660378b3b2a2c59e25c5f31) Review-Url: https://codereview.chromium.org/2938863002 . Cr-Commit-Position: refs/branch-heads/3112@{#342} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/9a79b8191b3ddf8e37b22fb8f063278c592c07d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -59 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc View 11 chunks +24 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/accessibility/magnification_manager_browsertest.cc View 11 chunks +23 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/file_manager/path_util_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/crash_restore_browsertest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 4 chunks +14 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/users/user_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/profiles/profile_helper.h View 1 chunk +7 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/profiles/profile_helper.cc View 4 chunks +12 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/status/data_promo_notification_unittest.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/download/notification/download_notification_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/braille_display_private/braille_display_private_apitest.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_manager.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 3 chunks +12 lines, -5 lines 0 comments Download
M chrome/browser/profiles/profile_manager_unittest.cc View 2 chunks +49 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_new_window_client_browsertest.cc View 4 chunks +14 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
xiyuan
3 years, 6 months ago (2017-06-14 16:03:06 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9a79b8191b3ddf8e37b22fb8f063278c592c07d5.

Powered by Google App Engine
This is Rietveld 408576698