Rename ClosureClassMaps to ClosureDataLookup

Rename ClosureClassMaps to CLosureDataLookup
(doing small tasks while I wait to talk to Siggi).

BUG=
R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/e6d7c0500c4403e4f26a13ecdd57b4ab7197ba30

[Emily Fortuna, 2017-06-14 21:02:55]

efortuna@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-06-14 23:17:12]

lgtm

https://codereview.chromium.org/2938853004/diff/1/pkg/compiler/lib/src/closur...
File pkg/compiler/lib/src/closure.dart (right):

https://codereview.chromium.org/2938853004/diff/1/pkg/compiler/lib/src/closur...
pkg/compiler/lib/src/closure.dart:5: library closureDataLookup;
nit: the convention is to use a lower.case.name.with.dots_and_underscores. Here
I'd use:

compiler.src.closure or compiler.src.closure_data;

we could also just drop the library tag here, it is not needed. I only include
it when I want to have a library-level dartdoc

https://codereview.chromium.org/2938853004/diff/1/pkg/compiler/lib/src/closur...
pkg/compiler/lib/src/closure.dart:29: /// to preserve Dart semantics in other
situations. Given a particular node to
not sure I follow the prat "in other situations" here. Maybe replace with "when
compiled to JavaScript"?

https://codereview.chromium.org/2938853004/diff/1/pkg/compiler/lib/src/closur...
pkg/compiler/lib/src/closure.dart:32: abstract class ClosureDataLookup<T> {
another reason I'd change *Info below to *Data :-)

https://codereview.chromium.org/2938853004/diff/1/pkg/compiler/lib/src/compil...
File pkg/compiler/lib/src/compiler.dart (right):

https://codereview.chromium.org/2938853004/diff/1/pkg/compiler/lib/src/compil...
pkg/compiler/lib/src/compiler.dart:147: closureMapping.ClosureTask
closureDataLookup;
not sure if there are some dependencies that still use other APIs ClosureTask,
but if not, it might be nice to also change the type here to be
ClosureDataLookup<Node> instead of ClosureTask.

If this pulls more stuff in, no worries, we'll get to it later.

[Emily Fortuna, 2017-06-14 23:44:13]

https://codereview.chromium.org/2938853004/diff/1/pkg/compiler/lib/src/closur...
File pkg/compiler/lib/src/closure.dart (right):

https://codereview.chromium.org/2938853004/diff/1/pkg/compiler/lib/src/closur...
pkg/compiler/lib/src/closure.dart:5: library closureDataLookup;
On 2017/06/14 23:17:12, Siggi Cherem (dart-lang) wrote:
> nit: the convention is to use a lower.case.name.with.dots_and_underscores.
Here
> I'd use:
> 
> compiler.src.closure or compiler.src.closure_data;
> 
> we could also just drop the library tag here, it is not needed. I only include
> it when I want to have a library-level dartdoc

removed

https://codereview.chromium.org/2938853004/diff/1/pkg/compiler/lib/src/closur...
pkg/compiler/lib/src/closure.dart:29: /// to preserve Dart semantics in other
situations. Given a particular node to
On 2017/06/14 23:17:12, Siggi Cherem (dart-lang) wrote:
> not sure I follow the prat "in other situations" here. Maybe replace with
"when
> compiled to JavaScript"?

Done.

https://codereview.chromium.org/2938853004/diff/1/pkg/compiler/lib/src/closur...
pkg/compiler/lib/src/closure.dart:32: abstract class ClosureDataLookup<T> {
On 2017/06/14 23:17:12, Siggi Cherem (dart-lang) wrote:
> another reason I'd change *Info below to *Data :-)

I messaged you in chat about this:

For me, as a native English speaker, "data" has a slightly different sense than
"info", which is why I used one in one place and one in the other. 

"info" basically always refers to a single bit of information
whereas "data" can refer to to the collective of details
hence me using "info" in one place and "data" in the other
do you still think I should keep it "data" throughout?

https://codereview.chromium.org/2938853004/diff/1/pkg/compiler/lib/src/compil...
File pkg/compiler/lib/src/compiler.dart (right):

https://codereview.chromium.org/2938853004/diff/1/pkg/compiler/lib/src/compil...
pkg/compiler/lib/src/compiler.dart:147: closureMapping.ClosureTask
closureDataLookup;
On 2017/06/14 23:17:12, Siggi Cherem (dart-lang) wrote:
> not sure if there are some dependencies that still use other APIs ClosureTask,
> but if not, it might be nice to also change the type here to be
> ClosureDataLookup<Node> instead of ClosureTask.
> 
> If this pulls more stuff in, no worries, we'll get to it later.

Done.

[Emily Fortuna, 2017-06-14 23:54:12]

https://codereview.chromium.org/2938853004/diff/1/pkg/compiler/lib/src/compil...
File pkg/compiler/lib/src/compiler.dart (right):

https://codereview.chromium.org/2938853004/diff/1/pkg/compiler/lib/src/compil...
pkg/compiler/lib/src/compiler.dart:147: closureMapping.ClosureTask
closureDataLookup;
On 2017/06/14 23:44:13, Emily Fortuna wrote:
> On 2017/06/14 23:17:12, Siggi Cherem (dart-lang) wrote:
> > not sure if there are some dependencies that still use other APIs
ClosureTask,
> > but if not, it might be nice to also change the type here to be
> > ClosureDataLookup<Node> instead of ClosureTask.
> > 
> > If this pulls more stuff in, no worries, we'll get to it later.
> 
> Done.

oh, and update to this -- this requires more changes because
element_strategy.dart calls "createClosureClasses" which is on ClosureTask but
not ClosureDataLookup. However, I was noticing as I've been working on the next
CL that this existing layout should change. So, expect that in a followup CL.

[Emily Fortuna, 2017-06-14 23:55:29]

Patchset #2 (id:20001) has been deleted

[Emily Fortuna, 2017-06-14 23:56:01]

Description was changed from

==========
Rename ClosureClassMaps to CLosureDataLookup
(doing small tasks while I wait to talk to Siggi).

BUG=
==========

to

==========
Rename ClosureClassMaps to CLosureDataLookup
(doing small tasks while I wait to talk to Siggi).

BUG=
R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e6d7c0500c4403e4f26a13ecdd57b4ab7197ba30
==========

[Emily Fortuna, 2017-06-14 23:56:02]

Committed patchset #2 (id:40001) manually as
e6d7c0500c4403e4f26a13ecdd57b4ab7197ba30 (presubmit successful).

[Siggi Cherem (dart-lang), 2017-06-15 00:09:01]

lgtm

https://codereview.chromium.org/2938853004/diff/1/pkg/compiler/lib/src/closur...
File pkg/compiler/lib/src/closure.dart (right):

https://codereview.chromium.org/2938853004/diff/1/pkg/compiler/lib/src/closur...
pkg/compiler/lib/src/closure.dart:32: abstract class ClosureDataLookup<T> {
On 2017/06/14 23:44:13, Emily Fortuna wrote:
> On 2017/06/14 23:17:12, Siggi Cherem (dart-lang) wrote:
> > another reason I'd change *Info below to *Data :-)
> 
> I messaged you in chat about this:
> 
> For me, as a native English speaker, "data" has a slightly different sense
than
> "info", which is why I used one in one place and one in the other. 
> 
> "info" basically always refers to a single bit of information
> whereas "data" can refer to to the collective of details
> hence me using "info" in one place and "data" in the other
> do you still think I should keep it "data" throughout?

Thanks, to bring the full loop of the discussion: "info" sgtm :) - we should
review existing uses of Data elsewhere in the compiler and change to Info if
they fit in a similar category. Very low-pri though :)