Rename ClosureClassMaps to ClosureDataLookup

pkg/compiler/lib/src/closure.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-library closureToClassMapper;
+library closureDataLookup;

[Siggi Cherem (dart-lang), 2017/06/14 23:17:12]

nit: the convention is to use a lower.case.name.with.dots_and_underscores. Here
I'd use:

compiler.src.closure or compiler.src.closure_data;

we could also just drop the library tag here, it is not needed. I only include
it when I want to have a library-level dartdoc

[Emily Fortuna, 2017/06/14 23:44:13]

removed

 
 import 'common/names.dart' show Identifiers;
 import 'common/resolution.dart' show ParsingContext, Resolution;
 import 'common/tasks.dart' show CompilerTask;
 import 'common.dart';
 import 'compiler.dart' show Compiler;
 import 'constants/expressions.dart';
 import 'elements/elements.dart';
 import 'elements/entities.dart';
 import 'elements/entity_utils.dart' as utils;
 import 'elements/modelx.dart'
     show BaseFunctionElementX, ClassElementX, ElementX;
 import 'elements/resolution_types.dart';
 import 'elements/types.dart';
 import 'elements/visitor.dart' show ElementVisitor;
 import 'js_backend/js_backend.dart' show JavaScriptBackend;
 import 'resolution/tree_elements.dart' show TreeElements;
 import 'package:front_end/src/fasta/scanner.dart' show Token;
 import 'tree/tree.dart';
 import 'util/util.dart';
 import 'world.dart' show ClosedWorldRefiner;
 
-/// Where T is ir.Node or Node.
-// TODO(efortuna): Rename this class.
-abstract class ClosureClassMaps<T> {
+/// Class that provides information for how closures are rewritten/represented
+/// to preserve Dart semantics in other situations. Given a particular node to

[Siggi Cherem (dart-lang), 2017/06/14 23:17:12]

not sure I follow the prat "in other situations" here. Maybe replace with "when
compiled to JavaScript"?

[Emily Fortuna, 2017/06/14 23:44:13]

Done.

+/// look up, it returns a information about the internal representation of how
+/// closure conversion is implemented. T is an ir.Node or Node.
+abstract class ClosureDataLookup<T> {

[Siggi Cherem (dart-lang), 2017/06/14 23:17:12]

another reason I'd change *Info below to *Data :-)

[Emily Fortuna, 2017/06/14 23:44:13]

I messaged you in chat about this:

For me, as a native English speaker, "data" has a slightly different sense than
"info", which is why I used one in one place and one in the other. 

"info" basically always refers to a single bit of information
whereas "data" can refer to to the collective of details
hence me using "info" in one place and "data" in the other
do you still think I should keep it "data" throughout?

[Siggi Cherem (dart-lang), 2017/06/15 00:09:01]

Thanks, to bring the full loop of the discussion: "info" sgtm :) - we should
review existing uses of Data elsewhere in the compiler and change to Info if
they fit in a similar category. Very low-pri though :)

   /// Look up information about the variables that have been mutated and are
   /// used inside the scope of [node].
   // TODO(johnniwinther): Split this up into two functions, one for members and
   // one for local functions.
   ClosureRepresentationInfo getClosureRepresentationInfo(Entity member);
 
   /// Look up information about a loop, in case any variables it declares need
   /// to be boxed/snapshotted.
   LoopClosureRepresentationInfo getClosureRepresentationInfoForLoop(T loopNode);
 
@@ skipping 146 matching lines @@
   /// Return true if [variable] has been captured and mutated (all other
   /// variables do not require boxing).
   bool isVariableBoxed(Local variable) => false;
 
   // TODO(efortuna): Remove this method. The old system was using
   // ClosureClassMaps for situations other than closure class maps, and that's
   // just confusing.
   bool get isClosure => false;
 }
 
-class ClosureTask extends CompilerTask implements ClosureClassMaps<Node> {
+class ClosureTask extends CompilerTask implements ClosureDataLookup<Node> {
   Map<Node, ClosureScope> _closureInfoMap = <Node, ClosureScope>{};
   Map<Element, ClosureClassMap> _closureMappingCache =
       <Element, ClosureClassMap>{};
   Compiler compiler;
   ClosureTask(Compiler compiler)
       : compiler = compiler,
         super(compiler.measurer);
 
   String get name => "Closure Simplifier";
 
@@ skipping 1236 matching lines @@
 ///
 /// Move the below classes to a JS model eventually.
 ///
 abstract class JSEntity implements MemberEntity {
   Local get declaredEntity;
 }
 
 abstract class PrivatelyNamedJSEntity implements JSEntity {
   Entity get rootOfScope;
 }