Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: pkg/compiler/lib/src/js_emitter/program_builder/collector.dart

Issue 2938823002: Starting making dart2js strong mode clean. (Closed)
Patch Set: Address some comments. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/program_builder/collector.dart
diff --git a/pkg/compiler/lib/src/js_emitter/program_builder/collector.dart b/pkg/compiler/lib/src/js_emitter/program_builder/collector.dart
index f298bbe499a3c3985b8b23a585b67d347d92dcb2..260b23ac322d265251876f7ba44c382db99f94d3 100644
--- a/pkg/compiler/lib/src/js_emitter/program_builder/collector.dart
+++ b/pkg/compiler/lib/src/js_emitter/program_builder/collector.dart
@@ -145,8 +145,8 @@ class Collector {
element.isConstructor ||
element.isSetter)) {
MethodElement function = element;
- function.functionSignature
- .forEachParameter(_mirrorsData.retainMetadataOfParameter);
+ function.functionSignature.forEachParameter((parameter) =>
+ _mirrorsData.retainMetadataOfParameter(parameter));
}
}
}
@@ -156,7 +156,7 @@ class Collector {
_mirrorsData.retainMetadataOfClass(cls);
new FieldVisitor(_options, _elementEnvironment, _worldBuilder,
_nativeData, _mirrorsData, _namer, _closedWorld)
- .visitFields((FieldElement member,
+ .visitFields((FieldEntity member,
js.Name name,
js.Name accessorName,
bool needsGetter,
@@ -334,7 +334,7 @@ class Collector {
}
});
- _sorter.sortMembers(fields).forEach(addToOutputUnit);
+ _sorter.sortMembers(fields).forEach((MemberEntity e) => addToOutputUnit(e));
}
void computeNeededLibraries() {
« no previous file with comments | « pkg/compiler/lib/src/js_backend/namer.dart ('k') | pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698