Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 2938813002: Report ie11 timeouts in debug log, not as errors (attempt 2) (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index e514301a8d787704cd605eb381c58ffaa0d657c2..69702006b548a0048b9e44d177b3ba3127f4b805 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -1103,7 +1103,13 @@ class BrowserCommandOutputImpl extends CommandOutputImpl {
if (_infraFailure) {
return Expectation.ignore;
}
-
+ // TODO(28955): See http://dartbug.com/28955
+ // The code for this in _failedBecauseOfFlakyInfrastructure doesn't
+ // seem to be working.
+ if (hasTimedOut && testCase.configuration.runtime == Runtime.ie11) {
+ DebugLogger.warning("Timeout of ie11 on test ${testCase.displayName}");
+ return Expectation.ignore;
+ }
// Handle crashes and timeouts first
if (hasCrashed) return Expectation.crash;
if (hasTimedOut) return Expectation.timeout;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698