Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: tools/testing/dart/test_runner.dart

Issue 2938813002: Report ie11 timeouts in debug log, not as errors (attempt 2) (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for executing tests. 6 * Classes and methods for executing tests.
7 * 7 *
8 * This module includes: 8 * This module includes:
9 * - Managing parallel execution of tests, including timeout checks. 9 * - Managing parallel execution of tests, including timeout checks.
10 * - Evaluating the output of each test as pass/fail/crash/timeout. 10 * - Evaluating the output of each test as pass/fail/crash/timeout.
(...skipping 1085 matching lines...) Expand 10 before | Expand all | Expand 10 after
1096 bool compilationSkipped) 1096 bool compilationSkipped)
1097 : _infraFailure = 1097 : _infraFailure =
1098 _failedBecauseOfFlakyInfrastructure(command, timedOut, stderr), 1098 _failedBecauseOfFlakyInfrastructure(command, timedOut, stderr),
1099 super(command, exitCode, timedOut, stdout, stderr, time, 1099 super(command, exitCode, timedOut, stdout, stderr, time,
1100 compilationSkipped, 0); 1100 compilationSkipped, 0);
1101 1101
1102 Expectation result(TestCase testCase) { 1102 Expectation result(TestCase testCase) {
1103 if (_infraFailure) { 1103 if (_infraFailure) {
1104 return Expectation.ignore; 1104 return Expectation.ignore;
1105 } 1105 }
1106 1106 // TODO(28955): See http://dartbug.com/28955
1107 // The code for this in _failedBecauseOfFlakyInfrastructure doesn't
1108 // seem to be working.
1109 if (hasTimedOut && testCase.configuration.runtime == Runtime.ie11) {
1110 DebugLogger.warning("Timeout of ie11 on test ${testCase.displayName}");
1111 return Expectation.ignore;
1112 }
1107 // Handle crashes and timeouts first 1113 // Handle crashes and timeouts first
1108 if (hasCrashed) return Expectation.crash; 1114 if (hasCrashed) return Expectation.crash;
1109 if (hasTimedOut) return Expectation.timeout; 1115 if (hasTimedOut) return Expectation.timeout;
1110 if (hasNonUtf8) return Expectation.nonUtf8Error; 1116 if (hasNonUtf8) return Expectation.nonUtf8Error;
1111 1117
1112 var outcome = _getOutcome(); 1118 var outcome = _getOutcome();
1113 1119
1114 if (testCase.hasRuntimeError) { 1120 if (testCase.hasRuntimeError) {
1115 if (!outcome.canBeOutcomeOf(Expectation.runtimeError)) { 1121 if (!outcome.canBeOutcomeOf(Expectation.runtimeError)) {
1116 return Expectation.missingRuntimeError; 1122 return Expectation.missingRuntimeError;
(...skipping 2112 matching lines...) Expand 10 before | Expand all | Expand 10 after
3229 } 3235 }
3230 } 3236 }
3231 3237
3232 void eventAllTestsDone() { 3238 void eventAllTestsDone() {
3233 for (var listener in _eventListener) { 3239 for (var listener in _eventListener) {
3234 listener.allDone(); 3240 listener.allDone();
3235 } 3241 }
3236 _allDone(); 3242 _allDone();
3237 } 3243 }
3238 } 3244 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698