Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2938783002:
chromium.webkit: Adjust shard numbers for <1h cycle times. (Closed)
Descriptionchromium.webkit: Adjust shard numbers for <1h cycle times.
* 'WebKit Linux Trusty ASAN' currently takes ~2.5 hrs
* 'WebKit Linux Trusty MSAN' currently takes ~6 hrs
* 'WebKit Linux Trusty Leak' currently takes ~1 hrs
* 'WebKit Linux Trusty (dbg)' currently takes ~3.5 hrs
BUG=703894, 524758
NOTRY=true
Review-Url: https://codereview.chromium.org/2938783002
Cr-Commit-Position: refs/heads/master@{#479604}
Committed: https://chromium.googlesource.com/chromium/src/+/51a69bcf539116e6d8ab573dc9ca263a61023ec2
Patch Set 1 #Patch Set 2 : Rebase onto master. #Messages
Total messages: 21 (13 generated)
The CQ bit was checked by tansell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== chromium.webkit: Adjust shard numbers for <1h cycle times. * 'WebKit Linux Trusty ASAN' currently takes ~2.5 hrs * 'WebKit Linux Trusty MSAN' currently takes ~6 hrs * 'WebKit Linux Trusty Leak' currently takes ~1 hrs * 'WebKit Linux Trusty (dbg)' currently takes ~3.5 hrs BUG=703894,524758 TBR=dpranke@chromium.org,mcgreevy@chromium.org,dsansome@chromium.org,phajdan@... ========== to ========== chromium.webkit: Adjust shard numbers for <1h cycle times. * 'WebKit Linux Trusty ASAN' currently takes ~2.5 hrs * 'WebKit Linux Trusty MSAN' currently takes ~6 hrs * 'WebKit Linux Trusty Leak' currently takes ~1 hrs * 'WebKit Linux Trusty (dbg)' currently takes ~3.5 hrs BUG=703894,524758 ==========
tansell@chromium.org changed reviewers: + phajdan.jr@chromium.org - phajdan@chromium.org
Hi Dirk! I would like to adjust the waterfall shard numbers to be these values. I believe this will mean that all the chromium.webkit Linux bots will cycle in under an hour. It will however require another ~50 bots in the Linux swarming pool. This will also be an static load (compared to the variable load that the tryservers have). Tim 'mithro' Ansell
LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
I'll wait until I get confirmation from Dirk that we have sufficient capacity in the swarming pool before landing this change.
On 2017/06/14 12:30:37, mithro wrote: > I'll wait until I get confirmation from Dirk that we have sufficient capacity in > the swarming pool before landing this change. It looks like we should be okay, although it'll push us close to current capacity. I can't really argue too much against this change, but it's not clear that this is the best thing to land, compared to looking at cycle times on other waterfalls or adding more configurations to the CQ. Ideally, we'd have a bunch more capacity and speed up everything and cover everything, but I don't have the cycles to do that at the moment. That said, I'm okay with landing this if for no other reason than that I'm curious to see how the capacity numbers actually change. We can revert it if need be.
lgtm
The CQ bit was checked by dsansome@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org, phajdan.jr@chromium.org Link to the patchset: https://codereview.chromium.org/2938783002/#ps20001 (title: "Rebase onto master.")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== chromium.webkit: Adjust shard numbers for <1h cycle times. * 'WebKit Linux Trusty ASAN' currently takes ~2.5 hrs * 'WebKit Linux Trusty MSAN' currently takes ~6 hrs * 'WebKit Linux Trusty Leak' currently takes ~1 hrs * 'WebKit Linux Trusty (dbg)' currently takes ~3.5 hrs BUG=703894,524758 ========== to ========== chromium.webkit: Adjust shard numbers for <1h cycle times. * 'WebKit Linux Trusty ASAN' currently takes ~2.5 hrs * 'WebKit Linux Trusty MSAN' currently takes ~6 hrs * 'WebKit Linux Trusty Leak' currently takes ~1 hrs * 'WebKit Linux Trusty (dbg)' currently takes ~3.5 hrs BUG=703894,524758 NOTRY=true ==========
The CQ bit was unchecked by tansell@chromium.org
The CQ bit was checked by tansell@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497501406918080,
"parent_rev": "19663e1dc06313c083dd486197f7a303b55f6577", "commit_rev":
"51a69bcf539116e6d8ab573dc9ca263a61023ec2"}
Message was sent while issue was closed.
Description was changed from ========== chromium.webkit: Adjust shard numbers for <1h cycle times. * 'WebKit Linux Trusty ASAN' currently takes ~2.5 hrs * 'WebKit Linux Trusty MSAN' currently takes ~6 hrs * 'WebKit Linux Trusty Leak' currently takes ~1 hrs * 'WebKit Linux Trusty (dbg)' currently takes ~3.5 hrs BUG=703894,524758 NOTRY=true ========== to ========== chromium.webkit: Adjust shard numbers for <1h cycle times. * 'WebKit Linux Trusty ASAN' currently takes ~2.5 hrs * 'WebKit Linux Trusty MSAN' currently takes ~6 hrs * 'WebKit Linux Trusty Leak' currently takes ~1 hrs * 'WebKit Linux Trusty (dbg)' currently takes ~3.5 hrs BUG=703894,524758 NOTRY=true Review-Url: https://codereview.chromium.org/2938783002 Cr-Commit-Position: refs/heads/master@{#479604} Committed: https://chromium.googlesource.com/chromium/src/+/51a69bcf539116e6d8ab573dc9ca... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/51a69bcf539116e6d8ab573dc9ca... |
