Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 2938683002: [turbofan] Inline ReturnReceiver builtin into TurboFan. (Closed)

Created:
3 years, 6 months ago by Benedikt Meurer
Modified:
3 years, 6 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Inline ReturnReceiver builtin into TurboFan. Builtins::kReturnReceiver is used for the Symbol.iterator function on iterators, and just returns the iterator itself. For example, for-of or yield* with a generator will first call generator[Symbol.iterator](), which simply returns the generator itself. Inlining this particular builtin into TurboFan is trivial and avoids that call completely, enabling more possibilities for LoadElimination and EscapeAnalysis to get rid of even more checks in common generator code. BUG=v8:6344, v8:6351, v8:6354 R=jgruber@chromium.org Review-Url: https://codereview.chromium.org/2938683002 Cr-Commit-Position: refs/heads/master@{#45927} Committed: https://chromium.googlesource.com/v8/v8/+/aea68b5a2601d9a86381d7301515dbc5f9eb4ca7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M src/compiler/js-call-reducer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-call-reducer.cc View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Benedikt Meurer
3 years, 6 months ago (2017-06-13 19:17:49 UTC) #1
Benedikt Meurer
Hey Jakob, Here's another pretty obvious one :-) Please take a look. Thanks, Benedikt
3 years, 6 months ago (2017-06-13 19:18:26 UTC) #4
jgruber
lgtm
3 years, 6 months ago (2017-06-13 19:29:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2938683002/1
3 years, 6 months ago (2017-06-13 19:29:57 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-13 19:48:22 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/aea68b5a2601d9a86381d7301515dbc5f9e...

Powered by Google App Engine
This is Rietveld 408576698