[Payment Request] Selector view edit mode

ios/chrome/browser/ui/payments/payment_request_selector_view_controller.h

Index: ios/chrome/browser/ui/payments/payment_request_selector_view_controller.h
diff --git a/ios/chrome/browser/ui/payments/payment_request_selector_view_controller.h b/ios/chrome/browser/ui/payments/payment_request_selector_view_controller.h
index 847c01d6c054f03a8b1dad51d6c2309a496c11a7..3964a8cb8c44b05fe91e12827883c8b0d70e53e0 100644
--- a/ios/chrome/browser/ui/payments/payment_request_selector_view_controller.h
+++ b/ios/chrome/browser/ui/payments/payment_request_selector_view_controller.h
@@ -8,9 +8,9 @@
 #import <UIKit/UIKit.h>
 
 #import "ios/chrome/browser/ui/collection_view/collection_view_controller.h"
+#import "ios/chrome/browser/ui/payments/payment_request_selector_view_controller_data_source.h"
 
 @class PaymentRequestSelectorViewController;
-@protocol PaymentRequestSelectorViewControllerDataSource;
 
 // Delegate protocol for PaymentRequestSelectorViewController.
 @protocol PaymentRequestSelectorViewControllerDelegate<NSObject>
@@ -31,6 +31,16 @@
 - (void)paymentRequestSelectorViewControllerDidSelectAddItem:
     (PaymentRequestSelectorViewController*)controller;
 
+// Notifies the delegate that the view controller's state has changed.
+- (void)paymentRequestSelectorViewController:
+            (PaymentRequestSelectorViewController*)controller
+                            didChangeToState:(PaymentRequestSelectorState)state;

[lpromero, 2017/06/14 09:10:12]

The implementation doesn't seem to notify when changing to the other states than
Edit and Normal.
Should the new Edit/Normal state be considered orthogonal entirely?

[Moe, 2017/06/14 14:35:05]

Done. You certainly have a point. Using the PaymentRequestSelectorState for the
edit mode guaranteed that the edit mode can't happen at the same time as the
pending or the error states. But it creates this discrepancy in when the view
controller does or doesn't notify the coordinator of the state change.  
I think its more appropriate to have an internal boolean state to manage the
edit mode and make sure the edit button only appears in the normal state to
begin with.

+
+// Notifies the delegate that the user has chosen to edit an item at |index|.
+- (void)paymentRequestSelectorViewController:
+            (PaymentRequestSelectorViewController*)controller
+              didSelectItemAtIndexForEditing:(NSUInteger)index;
+
 @end
 
 // View controller responsible for presenting a list of items provided by the