[Payment Request] Selector view edit mode

ios/chrome/browser/ui/payments/payment_request_selector_view_controller.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_CHROME_BROWSER_UI_PAYMENTS_PAYMENT_REQUEST_SELECTOR_VIEW_CONTROLLER_H_
 #define IOS_CHROME_BROWSER_UI_PAYMENTS_PAYMENT_REQUEST_SELECTOR_VIEW_CONTROLLER_H_
 
 #import <UIKit/UIKit.h>
 
 #import "ios/chrome/browser/ui/collection_view/collection_view_controller.h"
+#import "ios/chrome/browser/ui/payments/payment_request_selector_view_controller_data_source.h"
 
 @class PaymentRequestSelectorViewController;
-@protocol PaymentRequestSelectorViewControllerDataSource;
 
 // Delegate protocol for PaymentRequestSelectorViewController.
 @protocol PaymentRequestSelectorViewControllerDelegate<NSObject>
 
 // Notifies the delegate that the user has selected an item at the given index.
 - (void)paymentRequestSelectorViewController:
             (PaymentRequestSelectorViewController*)controller
                         didSelectItemAtIndex:(NSUInteger)index;
 
 // Notifies the delegate that the user has chosen to return to the previous
 // screen without making a selection.
 - (void)paymentRequestSelectorViewControllerDidFinish:
     (PaymentRequestSelectorViewController*)controller;
 
 @optional
 
 // Notifies the delegate that the user has chosen to add an item.
 - (void)paymentRequestSelectorViewControllerDidSelectAddItem:
     (PaymentRequestSelectorViewController*)controller;
 
+// Notifies the delegate that the view controller's state has changed.
+- (void)paymentRequestSelectorViewController:
+            (PaymentRequestSelectorViewController*)controller
+                            didChangeToState:(PaymentRequestSelectorState)state;

[lpromero, 2017/06/14 09:10:12]

The implementation doesn't seem to notify when changing to the other states than
Edit and Normal.
Should the new Edit/Normal state be considered orthogonal entirely?

[Moe, 2017/06/14 14:35:05]

Done. You certainly have a point. Using the PaymentRequestSelectorState for the
edit mode guaranteed that the edit mode can't happen at the same time as the
pending or the error states. But it creates this discrepancy in when the view
controller does or doesn't notify the coordinator of the state change.  
I think its more appropriate to have an internal boolean state to manage the
edit mode and make sure the edit button only appears in the normal state to
begin with.

+
+// Notifies the delegate that the user has chosen to edit an item at |index|.
+- (void)paymentRequestSelectorViewController:
+            (PaymentRequestSelectorViewController*)controller
+              didSelectItemAtIndexForEditing:(NSUInteger)index;
+
 @end
 
 // View controller responsible for presenting a list of items provided by the
 // supplied data source for selection by the user and communicating the choice
 // to the supplied delegate. It displays an optional header item provided by the
 // data source above the list of selectable items. The list is followed by an
 // optional button to add an item.
 @interface PaymentRequestSelectorViewController : CollectionViewController
 
 // The delegate to be notified when the user selects an item, returns without
 // selection, or decides to add an item.
 @property(nonatomic, weak) id<PaymentRequestSelectorViewControllerDelegate>
     delegate;
 
 // The data source for this view controller.
 @property(nonatomic, weak) id<PaymentRequestSelectorViewControllerDataSource>
     dataSource;
 
 // Convenience initializer. Initializes this object with the
 // CollectionViewControllerStyleAppBar style and sets up the leading (back)
 // button.
 - (instancetype)init;
 
 @end
 
 #endif  // IOS_CHROME_BROWSER_UI_PAYMENTS_PAYMENT_REQUEST_SELECTOR_VIEW_CONTROLLER_H_