Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2938663002: DevTools: Remove vertical padding on text button (Closed)

Created:
3 years, 6 months ago by einbinder
Modified:
3 years, 5 months ago
Reviewers:
lushnikov, luoe
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Remove vertical padding on text button The text button has a fixed height, so it doesn't need vertical padding. The padding caused the text to be not centered on Windows. BUG=none Review-Url: https://codereview.chromium.org/2938663002 Cr-Commit-Position: refs/heads/master@{#485134} Committed: https://chromium.googlesource.com/chromium/src/+/3128fe4c0e142cccc214cdd002f661eea34f7417

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/ui/textButton.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
einbinder
ptal
3 years, 6 months ago (2017-06-13 18:55:41 UTC) #2
luoe
lgtm, thanks!
3 years, 5 months ago (2017-06-28 22:52:28 UTC) #3
einbinder
Ptal
3 years, 5 months ago (2017-06-29 17:24:43 UTC) #5
einbinder
Ptal
3 years, 5 months ago (2017-06-29 17:24:46 UTC) #6
lushnikov
lgtm
3 years, 5 months ago (2017-07-07 23:35:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2938663002/1
3 years, 5 months ago (2017-07-08 00:57:44 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-07-08 02:44:37 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3128fe4c0e142cccc214cdd002f6...

Powered by Google App Engine
This is Rietveld 408576698