Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1017)

Issue 2938603002: [arm64] Make ArgumentsAdaptorTrampoline maintain 16-byte stack alignment. (Closed)

Created:
3 years, 6 months ago by georgia.kouveli
Modified:
3 years, 6 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[arm64] Make ArgumentsAdaptorTrampoline maintain 16-byte stack alignment. This is to help the transition to using CSP as the stack pointer. It does not make JSSP aligned yet, just makes sure that we only modify JSSP by a multiple of 16 bytes. To do this, we might need to add a padding slot above the receiver. BUG= Review-Url: https://codereview.chromium.org/2938603002 Cr-Commit-Position: refs/heads/master@{#46030} Committed: https://chromium.googlesource.com/v8/v8/+/dc2f3c1def225890273d513552b142fb84e65608

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -103 lines) Patch
M src/builtins/arm64/builtins-arm64.cc View 4 chunks +148 lines, -103 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
georgia.kouveli
3 years, 6 months ago (2017-06-13 14:34:39 UTC) #2
Benedikt Meurer
lgtm
3 years, 6 months ago (2017-06-20 05:12:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2938603002/1
3 years, 6 months ago (2017-06-20 09:21:12 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 09:51:20 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/dc2f3c1def225890273d513552b142fb84e...

Powered by Google App Engine
This is Rietveld 408576698