Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2938573002: Improve recovery from compile-time errors. (Closed)

Created:
3 years, 6 months ago by ahe
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -40 lines) Patch
M pkg/analyzer/test/generated/parser_fasta_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/builder/library_builder.dart View 3 chunks +12 lines, -9 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 5 chunks +14 lines, -6 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 5 chunks +29 lines, -8 lines 0 comments Download
M pkg/front_end/lib/src/fasta/loader.dart View 3 chunks +28 lines, -11 lines 0 comments Download
M pkg/front_end/test/fasta/compile.status View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/testcases/cycles.dart.direct.expect View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_local_function_return_type.dart.strong.expect View 1 chunk +28 lines, -3 lines 0 comments Download
M pkg/kernel/lib/core_types.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/kernel/lib/transformations/continuation.dart View 2 chunks +5 lines, -1 line 0 comments Download
M tests/co19/co19-kernel.status View 1 chunk +10 lines, -0 lines 0 comments Download
M tests/language/language_kernel.status View 1 chunk +9 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (2 generated)
ahe
3 years, 6 months ago (2017-06-13 10:04:58 UTC) #2
danrubel
LGTM
3 years, 6 months ago (2017-06-13 13:48:09 UTC) #3
Paul Berry
lgtm
3 years, 6 months ago (2017-06-13 13:49:42 UTC) #4
ahe
3 years, 6 months ago (2017-06-13 14:00:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
db2e915aacb4c309e959e1d121953bec681aadee (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698